1825468 - Move http3server off mio 0.6

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Mike Hommey [:glandium]]

Now that the old audioipc code is gone (bug 1697845), finally removing tokio 0.1, http3server is the only remaining use of mio 0.6. I've taken a quick look at upgrading to mio 0.8, but because of the whole deal with timeouts and how mio doesn't handle them anymore, it's not a straightforward change, unfortunately. It kind of feels like http3server could move entirely to tokio, but that seems like a lot of extra work.

Valentin, Kershaw, any opinions?

Comment 1

[Kershaw Chang [:kershaw]]

(In reply to Mike Hommey [:glandium] from comment #0)

Now that the old audioipc code is gone (bug 1697845), finally removing tokio 0.1, http3server is the only remaining use of mio 0.6. I've taken a quick look at upgrading to mio 0.8, but because of the whole deal with timeouts and how mio doesn't handle them anymore, it's not a straightforward change, unfortunately. It kind of feels like http3server could move entirely to tokio, but that seems like a lot of extra work.

Valentin, Kershaw, any opinions?

I agree that http3server needs to move to tokio, since using tokio should make us maintain http3server more easily.
What's the priority of this bug? If not really high, I can put this in my to-do list.

Comment 2

[Mike Hommey [:glandium]]

Not high, no.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Let's make it a P2 then.

Comment 4

[Manuel Bucher [:manuel]]

Upgrading mio has some the issue that the timer module was deprecated and removed, therefore we can't use the timer anymore for handling neqo timers.

Upgrading might help fixing some intermittents on windows:

• WouldBlock handling on windows: https://github.com/tokio-rs/mio/issues/1062 (Bug 1853677).

We might need to switch to something else like std with threading or async or some other lib that can provide timers.

Comment 5

[Mathew Hodson]

mio 0.6 was removed in bug 1895319