Closed Bug 1825543 Opened 6 months ago Closed 5 months ago

Unable to use Picture-in-Picture on UniFi Protect

Categories

(Toolkit :: Picture-in-Picture, enhancement, P3)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: gerard-majax, Assigned: dwalker)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fidefe-pip3])

Attachments

(1 file)

Bug 1825543 - relax PiP toggle req's to suppport videos without audio. r?#pip-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Using a camera via pip used to work, but it seems some recent update changed the way the content is being sent and we can no longer use PiP.

From some analysis:

  • <video> is connected to a WebRTC MediaStream
  • a second stream is available for the audio
  • the video element has no audio, mozHasAudio returns false

Thus we hit https://searchfox.org/mozilla-central/rev/0907529ff72c456ddb47839f5f7ba16291f28dce/toolkit/content/widgets/videocontrols.js#180-182

Component: WebRTC: Audio/Video → Video/Audio Controls
Product: Core → Toolkit

Hi Alexandre,

This happens as we don't offer PiP by default for videos with no audio.

As a temporary fix, you can flip this pref in about:config to true and it will override the current situation:
media.videocontrols.picture-in-picture.video-toggle.always-show

In the meantime, we are going to relax the requirements for video's PiP-pability and remove the audio track as a requirement.

Type: defect → enhancement
Priority: -- → P3
Whiteboard: [fidefe-pip3]
Assignee: nobody → dwalker
Component: Video/Audio Controls → Picture-in-Picture
Pushed by dwalker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3a25b467d9e
relax PiP toggle req's to suppport videos without audio. r=pip-reviewers,niklas

https://hg.mozilla.org/mozilla-central/rev/c3a25b467d9e

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Regressions: 1843088
You need to log in before you can comment on or make changes to this bug.