1843088 - In-video PiP button positioned incorrectly in Google Meets WebRTC calls

Status: RESOLVED WORKSFORME

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Jim Mathies [:jimm]]

Attachment: Screenshot 2023-07-12 103839.png

Reported to us by Google - in some cases for remote video feeds in Meet, the popout indicator is displayed such that it falls off the side of the video frame. See screenshot.

Web conferencing team will be scheduling Google Meet testing with QA to try and reproduce.

Comment 1

[Daniel Bodea [:danibodea]]

This issue appears to have started reproducing since the implementation of Bug 1825543.
Mozregression results:
2023-07-13T15:43:43.336000: DEBUG : Found commit message:
Bug 1825543 - relax PiP toggle req's to suppport videos without audio. r=pip-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D177939

Other information about this issue:

1. It does not happen for the user's own webcam stream.
2. It only occurs for the streams of other participants.
3. This happens when the whole stream does not fit inside the smaller size window or there are many participants in the call. This happens because the stream are being zoomed in and the PiP toggle spills out along with the margins of the videos.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1825543

Comment 3

[Jim Mathies [:jimm]]

Clearing this so it will get picked up in triage.

Comment 4

[Jim Mathies [:jimm]]

Hey Jonathan, would appreciate your team looking into this.

Comment 5

[Molly Howell (she/her) (mostly inactive)]

(In reply to Jim Mathies [:jimm] from comment #4)

Hey Jonathan, would appreciate your team looking into this.

Hello!

Jim, what's the priority on this for y'all? If it's urgent then we can go ahead and try something quick and dirty. Which would be either just hiding the toggle for Meet, or I think we could move it to the other side of the window (which would still look a bit weird, but it shouldn't get cut off that way).

Comment 6

[Jim Mathies [:jimm]]

(In reply to Molly Howell (she/her) [:mhowell] from comment #5)

(In reply to Jim Mathies [:jimm] from comment #4)

Hey Jonathan, would appreciate your team looking into this.

Hello!

Jim, what's the priority on this for y'all? If it's urgent then we can go ahead and try something quick and dirty. Which would be either just hiding the toggle for Meet, or I think we could move it to the other side of the window (which would still look a bit weird, but it shouldn't get cut off that way).

It's cosmetic in nature so it doesn't impact use, however it is a very visible cosmetic bug in a popular conferencing service. I'll defer to you all in setting priority. IMHO I would rather we try to fix it vs. something quick and dirty.

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Okay, thank you, we'll have a go at fixing this properly then.

After looking into this in some more detail, it's not as simple as I had hoped it would be to just relocate the toggle. It turns out what they're doing isn't a zoom, it's a crop; they're actually cutting off both sides of the video element itself down to a certain aspect ratio (which appears to be something close to 1:1) before they switch over to scaling it down. So our toggle is just getting cut out. To fix this, we would need to detect that happening and dynamically move the toggle so that it's still in view. I haven't looked into how complicated that is going to be yet, but it feels pretty workable.

Comment 8

[kpatenio]

Setting P2 - from this discussion, I'm getting the impression that we'd want to have a reliable fix as soon as we can, given how visible the issue is.
As for severity, I'm setting S3 since the toggle is still functional.

Comment 9

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1825543

Comment 10

[Donal Meehan [:dmeehan]]

:mhowell any updates on a fix, anything planned in time for Fx119?

Comment 11

[DJ]

:jimm I am currently unable to reproduce the issue in Nightly on MacOS. I checked with mhowell and she can't reproduce it on Windows either. It looks like the web app isn't doing the zoom/crop behavior anymore, so this may no longer be an issue.