182583 - Favicons should be displayed everywhere where toolbar bookmarks are displayed

Status: VERIFIED DUPLICATE of bug 223180

(Camino Graveyard :: Bookmarks, enhancement)

Description

[Martin Ler]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021128 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021128 Chimera/0.6+

Favicons should be displayed everywhere, where are displayed toolbar bookmarks
(bookmark drawer, menu, Dock menu). Navigation is quite hard if names of sites
are deleted

Reproducible: Always

Steps to Reproduce:
1. Put many of sites with favicons to toolbar
2. delete names for all of them, toolbar displai just icons
3. open bookmark menu, bookmark drawer or Dock-menu and try to find somethink

Actual Results:  
You can of couse find nothink :)


I would like to see the option, how to use just icons in toolbar (save lot of
space), but to preserve information which site is which on other places, where
toolbar bookmarks are shown
i give two proposals:
1) show favicons for toolbar bookmarks everywhere, where this bookmarks are
shown - bookmark drawer, bookmark menu, Dock menu. When name of bookmark is
deleted, at least icon is shown.
2) add option to hide name of bookmark in toolbar. Can be option - for every
bookmark extra (via "Get info" panel), or via preferences (show names for all
toolbar bookmarks/don't show names for toolbar bookmarks with favicon).

i think that second method is more correct from UI point of view, it's up to you
to choose, how user can choose which names to show and which not.

Comment 1

[Simon Fraser [no longer active]]

This was not done for performance reasons.

Comment 2

[Jasper]

I hope you understand that enabeling siteicons on all bookmarks will require a
cash file since all those images have to be stored. Other wise you will have to
wait on every launch of chimera untill all those images are loade form the net.
I don't think so!

If you want there is a way to manual add a pref that will enable the "show site
icons every where". But I can't remeber what it was.

I would rather keep it the way it's right now. But I would like to have the
feature where the names of the  bookmark in the bookmark toolbar could be
hidden. That way more bookmark fit in there without loosing the name info of the
bookmark. The problem I see would be that websites that don't use site icons
will be displayed with the general bookmark icon which could be very confusing
when using a lot of bookmarks in the toolbar.

Comment 3

[Martin Ler]

Jasper, sorry, my english is not perfect, but it seems to me, that you respond
to some different bug. I spoke JUST and ONLY about Toolbar bookmarks, i found
before that there was disabled siteicons for all bookmarks, like Simon wrote,
and this is not what i want.

And, for caching, Chimera is now using cache for this siteicons, they are cached
in same cache like all other files (~/Library/Application 
Support/Chimera/Profiles/default/xyz.slt/Cache). After crash (or manual delete
of cache files), siteicons are missing (because somethink was not saved, i think
- in case of crash) and you must manualy reload the page to get the icon back. 

Regarding what to show and what not in toolbar (icon/text), think that my point
2 from my original submision is describing exactly what i mean - and i think
that this is the right solution (point 2, second option - with preference
settings - there is no need to show siteicons in bookmarks, or dock or
elsewhere, and give you chance to show just siteicons for site which support it)

So, please, give me someone hint - is my english so bad, that you can't
understand what i wrote, or is Jasper simply speaking about "somethink completly
different"? Thanks in advance :) I would like to submit some more enhancements,
so i need to know, if i should hire a translator :)

Comment 4

[Brad Kemper]

I think both of Martin's suggested remedies are good. If we are caching 
the icons anyway, why not use them wherever bookmarks are shown, 
including history, go menu, etc.? 

And a "hide bookmark names in toolbar" checkbox would also be nice, 
without overcomplicating things. You could still have the bookmark name 
appear in a tool tip.

Comment 5

[Mark Mentovai]

Perhaps a separate cache should be maintained for icons.

I would plumb it so that the cache would never be dynamically updated, updates would 
only occur when visiting a page and fetching its icon.  Give it a generous size by default, 
keeping in mind that icons are small (re-encode everything as a 16x16 PNG if you like) 
and even the most demanding users probably wouldn't expect more than a thousand 
icons to be available.  Finally, tune the purge algorithm to unload icons for which no 
bookmark exists*, and purge the least recently verified icons first.

If there is to be any mass update (or initial gathering) of icons, it should be procedure 
specifically triggered by the user.  Doing a big bookmark import (or starting with a corrupt 
or missing cache) and launching hundreds or thousands of requests is almost definitely 
not what the user ever wants.

* or purge icons that have been unlinked as bookmarks are deleted or edited

Mark

Comment 6

[S Woodside]

*** Bug 180507 has been marked as a duplicate of this bug. ***

Comment 7

[ryan g]

Maybe some think that there "is no need" for this feature, but using the
website icons in bookmarks could really a nice way to liven things up,  and
different sites stand out better..... There is certainly no disadvantage to
adding it for the users that want it... Just let it be toggled on  and off..

In preferances| appearance
show website icons in bookmarks
show website icons in windows/tabs 

By the way- Make sure this does not interfere with the feature in
bookmarks that notifies you when a site makes changes by changing it's icon...
The notify icon should prevail..  

Is the feature likely to affect Mozilla if it is listed as a bug for Chimera?
Now there is a bug filed by me for this for Mozilla(windows).. If there
doesn't need to be one for both than u could mark bug# 2773 as a dup... I am new
to this so help me out here...  If it should not be a dup.. tell me and i'll add
some of your ideas that u have mentioned to the mozilla (windows) version of
this bug. 
Thanks for your help

Comment 8

[[e-mail]]

This is actually one feature I like in Safari better than Chimera. It really
makes looking up bookmarks in the menu a lot easier.

Comment 9

[Jasper]

*** This bug has been marked as a duplicate of 223180 ***