1825961 - Missing uplift approval flags on uplift patches causes BugBot to falsely complain

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[Suhaib Mujahid [:suhaib]]

Uplift patches created using the uplift workflow through Lando do not have approval flags (i.e., approval-mozilla-*). When such a patch is attached to a closed bug, autonag will consider it as a new patch, which triggers the bot to suggest opening a new bug (see mozilla/relman-auto-nag#1953).

Any of the following solutions could resolve the issue:

1. Keep backward compatibility with the current workflow by syncing the approval status with Bugzilla. So adding an approve request flag when attaching the uplift patch to the bug (e.g., approval-mozilla-beta?) and changing it to approved (e.g., approval-mozilla-beta+) when the patch lands or get approved on Phapricator.

2. Add a flag to identify the attachment as an uplift patch without syncing the approval status.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1825961: set `approval-mozilla-{repo}` flags on uplift revision attachments (#2054)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1825961: sync revision status with `approval-mozilla-{repo}` flag (#2056)

Comment 3

[Connor Sheehan [:sheehan]]

After the patches above are deployed, the approval-mozilla-{repo} flags will be added to new bug attachments for Phabricator revisions on uplift patches and the flag status will be synced with the Phabricator revision status.

Comment 4

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/ce12be220b55225ec9da941a98ece5c28fde33a6

Comment 5

[Suhaib Mujahid [:suhaib]]

The new uplift workflow appears to be failing to add approval flags to the uplift patches.

Example: https://bugzilla.mozilla.org/show_bug.cgi?id=1842547#c13

:sheehan could you please investigate the issue?

Comment 6

[Connor Sheehan [:sheehan]]

It seems to be intermittent, or at least not impacting every patch. You can see from this example that the approval flag is sometimes being set.

The example I've given shows the ESR flags being set, perhaps it's only beta which is broken. I'll need to investigate further.

Comment 7

[David Lawrence [:dkl]]

This should hopefully be fixed now with recent changes. Please reopen if this occurs again.