1825995 - Import SeaMonkey Installation - Continue Button does nothing

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Christoph Bratschi]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

1. Launch Thunderbird
2. Select import button
3. Select import from SeaMonkey installation
4. Continue button does nothing

Actual results:

Can click on the continue button as many times as I want but nothing happens. The wizard does not continue to step #2.

Expected results:

Wizard should continue.

All other browsers were closed at that time. Whatever I tried did not make a difference.

Comment 1

[Peter Kihlstedt :peki]

I can confirm that I have the same behaviour.
I have the latest release version of Seamonkey. 2.53.17 and have noticed this problem on version 102 of Thunderbird. I had hopes that it would improve with the 115.2.2 version, but no. The problem still exists.
I am also on Windows 10 64 bit version. I use localized versions of both Windows, Thunderbird and Seamonkey.

Comment 2

[Christoph Bratschi]

Yes, I tried all Thunderbird updates since then and nothing has changed.

I finally want to migrate from Seamonkey to Thunderbird (after many many years of using it solely as an email app). The wizard should be the safest way to import all data, if it would work.

Comment 3

[Magnus Melin [:mkmelin]]

Seems to work for me.
Try Thunderbird 115. Anything in the error console?

Comment 4

[Peter Kihlstedt :peki]

There are something in the error console:

Uncaught (in promise) NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.append]
getSourceProfiles resource:///modules/SeamonkeyProfileImporter.jsm:62
_onSelectSource chrome://messenger/content/aboutImport.js:377
_onSelectSource chrome://messenger/content/aboutImport.js:1390
next chrome://messenger/content/aboutImport.js:1349
onclick about:import#:1

Repeated 18 times, maybe because I clicked multiple times.

Comment 5

[Christoph Bratschi]

(In reply to Peter Kihlstedt :peki from comment #4)

There are something in the error console:

Uncaught (in promise) NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.append]
getSourceProfiles resource:///modules/SeamonkeyProfileImporter.jsm:62
_onSelectSource chrome://messenger/content/aboutImport.js:377
_onSelectSource chrome://messenger/content/aboutImport.js:1390
next chrome://messenger/content/aboutImport.js:1349
onclick about:import#:1

Repeated 18 times, maybe because I clicked multiple times.

I have the exactly same error in my JS console.

Comment 6

[Magnus Melin [:mkmelin]]

Check the profiles.ini of the profile you're trying to import.
https://searchfox.org/comm-central/rev/6c99f20d1bf4e5141338737a8f00b3b51826ae47/mailnews/import/modules/SeamonkeyProfileImporter.sys.mjs#52,62
initWithPath will fail throw if it gets a relative path. Is the IsRelative entry correct in the profiles.ini?

Comment 7

[Peter Kihlstedt :peki]

My profiles.ini is very simple with only six lines. Four of them for the default and only profile. And IsRelative is set to 1. Path is set to Profiles/profilecode.default, where profilecode is the 8 character random string.
Can I change IsRelative to 0? I guess I need to change the Path then as well. How should it look? "C:\Users\peter\AppData\Roaming\Mozilla\SeaMonkey\Profiles" ? Or can this be changed through a profile manager?

Comment 8

[Magnus Melin [:mkmelin]]

If it's indeed 1 (can you attach the .ini file?) then maybe the relative path is wrong? Did you check it's a correct relative path, relative from profiles.ini?

Comment 9

[Peter Kihlstedt :peki]

Attachment: profiles.ini

Attached is my profiles.ini file. And yes, the file is in the Seamonkey folder, the same folder as the Profiles folder, so the path is correct.

Comment 10

[Magnus Melin [:mkmelin]]

Is the profile in the standard location?
For me the Path does not include a "Profiles/", it's simply

IsRelative=1
Path=djj2yet1.default

Comment 11

[Peter Kihlstedt :peki]

Yes, the profile folder is in the location described here: https://www.seamonkey-project.org/doc/profiles. The line for Windows 7 seems to be correct also for Windows 10.

Comment 12

[Magnus Melin [:mkmelin]]

I realized what the problem is here. https://searchfox.org/comm-central/rev/6c99f20d1bf4e5141338737a8f00b3b51826ae47/mailnews/import/modules/SeamonkeyProfileImporter.sys.mjs#59 is supposed to append a child, but since you're setting is a path instead of a single folder it will fail...

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: Bug 1825995 - Fix SeamonkeyProfileImporter when relative path is more than one node deep. r=#thunderbird-reviewers

Comment 14

[Alessandro Castellani [:aleca]]

Can we create a follow up to this to add some tests?
We should add a UI test to ensure the buttons work here.
And then a dedicated unit test in here

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/15e9640f7dcd
Fix SeamonkeyProfileImporter when relative path is more than one node deep. r=aleca

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 9409162 [details]
Bug 1825995 - Fix SeamonkeyProfileImporter when relative path is more than one node deep. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: can't import in the relevant case
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): safe

Comment 17

[Corey Bryant]

Magnus, is there a follow up bug to add tests per comment 14?

Comment 18

[Magnus Melin [:mkmelin]]

No.
For the buttons, we seem to test that already, in general. The patch is for a SeaMonkey profile, and I'm not sure we can reasonably fake that in a test environment: it would require writing test data to an outside, very specific directory (or our importer wouldn't find it).

Comment 19

[Corey Bryant]

Comment on attachment 9409162 [details]
Bug 1825995 - Fix SeamonkeyProfileImporter when relative path is more than one node deep. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 20

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/344c9f714568

Comment 21

[Peter Kihlstedt :peki]

I now have Thunderbird 128.2.1 and can confirm that the import works for me.

Related, but not part of this bug, I noticed that only the first level of folders where imported. Folders within folders were not imported.

Comment 22

[Magnus Melin [:mkmelin]]

Please file a new bug for that.