1826009 - Tab icon of mail tab changes to the favicon of viewed HTML message and sticks

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P3)

Description

[Magnus Melin [:mkmelin]]

Attachment: favicon.eml

Load an html message with favicon. The favicon will be used for as tab icon, and stays there when navigating to another message.

Comment 1

[Thomas D. (:thomas8)]

(In reply to Magnus Melin [:mkmelin] from comment #0)

Created attachment 9326485 [details]
favicon.eml
Load an html message with favicon. The favicon will be used for as tab icon, and stays there when navigating to another message.

Confirming for 113.0a1 (2023-04-03) (64-bit), Win10.

• Selecting the message in message list is enough to make the icon hang around on the 3-pane tab even when other subfolders are selected. Only happens when message pane is shown.
• Only selecting a main folder like Inbox will update the icon again.
• Message opened in a tab will also have the icon, almost a feature ;-)

Not sure how many HTML messages with favicon are out there in the wild?

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1826009 - Restrict who can set tab icon. r=#thunderbird-reviewers

Document at mailbox://, imap:// etc. urls should not be allowed to set favicon.
Content tabs should be able to set favicon. (To test, openContentTab("https://google.com");)

Loading without restrictions is a privacy violation as well as unexpected UX.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/02d52dbca481
Restrict who can set tab icon. r=darktrojan

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9336929 [details]
Bug 1826009 - Restrict who can set tab icon. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: per bug description + privacy issue
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9336929 [details]
Bug 1826009 - Restrict who can set tab icon. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b747045ff7ec