1826072 - Allowed/ Blocked Temporarily permission is not correctly displayed inside the URL bar

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 113.0a1 (2023-04-02)

Affected versions

• 113.0a1 (2023-04-02)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open a camera or microphone permission page (e.g https://www.onlinemictest.com/) and allow or block microphone access.
2. Open the permission panel from the URL bar.
3. Observe the Allowed/ Blocked Temporarily permission string.

Expected result

• The permission string is correctly arranged.

Actual result

• The permission string is on two rows.

Regression range

• Last good revision: 2cc925315ab4bc13d89167646695eece8d6f6a63
  First bad revision: b50655fcce3faf31b2c1779c263ac7c1bca94863
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2cc925315ab4bc13d89167646695eece8d6f6a63&tochange=b50655fcce3faf31b2c1779c263ac7c1bca94863
  Potential regressor: bug 1822578.

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1822578, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1826072 - Use auto min-width for permission remove button. r=pbz,Gijs,dao

What we want is to not have a min-width from the default button styles,
but we still want it to take as much space as it needs, if available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98e9b5c1303
Use auto min-width for permission remove button. r=Gijs

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b98e9b5c1303

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

I am still seeing the same behavior with the latest Nightly 113.0a1 (20230403215207). The Allowed/Blocked Temporarily string is displayed on two rows. Is this ok? Thank you!

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1826072 - Update a couple selectors to use focus-visible instead of moz-focusring. r=Gijs,dao,itiel

Totally drive-by.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

No, you're totally right, thanks! I must've goofed my testing before landing the patch.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1826072 - Don't flex permission state label. r=Gijs,dao,itiel

Err, so the original patch is necessary but not sufficient, and I
clearly goofed my testing (I had removed this attribute in a separate
commit).

The issue is that this button ends up with a markup like:

<button class="permission-popup-permission-remove-button">
<label flex="1" class="permission-popup-permission-state-label">Allowed Temporarily</label>
<hbox class="box-inherit button-box" align="center" pack="center" flex="1" anonid="button-box">
<image class="button-icon"/>
<label class="button-text"/>
</hbox>
</button>

So the label and hbox divide the available space in half. Removing any
of the flex="1" attributes would cause the desired rendering.

I don't think the hbox needs to be flexible tbh, but ok, that's a
riskier change. I'm pretty sure the label in this case doesn't need to
be flexible at all though, specially since we don't want these buttons
to take any minimum amount of space.

An alternative would be to use flex: 1 auto or so for the label (via
CSS). That'd match the pre-regression behavior more exactly, but again I
don't think flexing the label is needed at all.

Depends on D174706

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2847afa663c
Update a couple selectors to use focus-visible instead of moz-focusring. r=Itiel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c9694fbbec
Don't flex permission state label. r=pbz

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2847afa663c
https://hg.mozilla.org/mozilla-central/rev/60c9694fbbec

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 113.0a1 (20230405212330) on Windows 10x64, macOS 12, and Ubuntu 22.04. The Allowed/Blocked Temporarily string is correctly displayed on one row as before.