1822578 - Buttons with longer labels became two-liners in about:preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Vlado Valastiak [:wladow]]

Attachment: comparison fx113 with two-liners on the left, fx112 with one-liners on the right

Many buttons in about:preferences became two-liners after landing bug 1822131. This is clearly visible in the latest Slovak Nightly build 20230315092641 (screenshot attached), there are even few buttons across the preferences UI in English build where this is visible (once you set intl.l10n.pseudo to accented you'll get even more of them).

Comment 1

[Vlado Valastiak [:wladow]]

Attachment: fx133_en-us_certificate

Comment 2

[Vlado Valastiak [:wladow]]

Attachment: fx133 en-us, you can even a three-liner with intl.l10n.pseudo set to accented

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822131

:emilio, since you are the author of the regressor, bug 1822131, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822578 - Make flex="1" on XUL set a zero flex basis like the flex shorthand does. r=dholbert!,Gijs,mconley

In a setup with:

<hbox>
<something flex="1"/>
<something-else/>
</hbox>

Before bug 1822131 <something flex="1"> ended up with flex-basis: auto,
but was the only thing able to shrink, so <something-else> stayed the
same size.

After that bug however <something-else> is able to shrink too, so both
elements shrink. This wouldn't happen if flex="1" actually worked like
flex: 1 does.

However flex: 1 causes stuff like explicit main sizes to be
(effectively) ignored, so we need to fix up a few cases where now we'd
start flexing too much. For that, add a debug assert to
nsFlexContainerFrame to catch the would-be behavior changes here.

For the most part they're actually no-op since they're setting tiny
sizes, but preferences and devtools needed a couple real fixes.

The profile selection spacer is useless (zero-size).

Hopefully the last xul.css change I need to do :')

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822578 - Flexbox debug assert for front-end. r=dholbert!

Depends on D172704

Comment 7

[Emilio Cobos Álvarez (:emilio)]

FYI, comment 6 has a patch that allows to detect cases where explicit sizes used to apply and won't after this. Fix is either removing that size if it's zero or so, using flex-basis: auto (e.g. change flex="1" to style="flex: 1 auto" if you do need the size to take effect).

Hopefully the last all-xul-is-affected change I need to do. Makes the setup much clearer tho (as flex="0" and flex="1" are symmetric now).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b50655fcce3f
Make flex="1" on XUL set a zero flex basis like the flex shorthand does. r=Gijs,mconley,settings-reviewers,desktop-theme-reviewers,dao

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b50655fcce3f