Closed Bug 1822578 Opened 2 years ago Closed 2 years ago

Buttons with longer labels became two-liners in about:preferences

Categories

(Firefox :: Settings UI, defect)

Firefox 113
defect

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 --- fixed

People

(Reporter: wladow, Assigned: emilio)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(4 files, 1 obsolete file)

Many buttons in about:preferences became two-liners after landing bug 1822131. This is clearly visible in the latest Slovak Nightly build 20230315092641 (screenshot attached), there are even few buttons across the preferences UI in English build where this is visible (once you set intl.l10n.pseudo to accented you'll get even more of them).

Attached image fx133_en-us_certificate

Set release status flags based on info from the regressing bug 1822131

:emilio, since you are the author of the regressor, bug 1822131, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
See Also: → 1822591

In a setup with:

<hbox>
<something flex="1"/>
<something-else/>
</hbox>

Before bug 1822131 <something flex="1"> ended up with flex-basis: auto,
but was the only thing able to shrink, so <something-else> stayed the
same size.

After that bug however <something-else> is able to shrink too, so both
elements shrink. This wouldn't happen if flex="1" actually worked like
flex: 1 does.

However flex: 1 causes stuff like explicit main sizes to be
(effectively) ignored, so we need to fix up a few cases where now we'd
start flexing too much. For that, add a debug assert to
nsFlexContainerFrame to catch the would-be behavior changes here.

For the most part they're actually no-op since they're setting tiny
sizes, but preferences and devtools needed a couple real fixes.

The profile selection spacer is useless (zero-size).

Hopefully the last xul.css change I need to do :')

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Duplicate of this bug: 1822591

Depends on D172704

FYI, comment 6 has a patch that allows to detect cases where explicit sizes used to apply and won't after this. Fix is either removing that size if it's zero or so, using flex-basis: auto (e.g. change flex="1" to style="flex: 1 auto" if you do need the size to take effect).

Hopefully the last all-xul-is-affected change I need to do. Makes the setup much clearer tho (as flex="0" and flex="1" are symmetric now).

Flags: needinfo?(mkmelin+mozilla)
Attachment #9323299 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b50655fcce3f Make flex="1" on XUL set a zero flex basis like the flex shorthand does. r=Gijs,mconley,settings-reviewers,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Regressions: 1822837
Regressions: 1822967
Regressions: 1823088
Regressions: 1823144
Regressions: 1823403
Regressions: 1825185
Flags: needinfo?(mkmelin+mozilla)
Regressions: 1841186
Regressions: 1861349
Regressions: 1873002
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: