Closed Bug 1826152 Opened 2 years ago Closed 7 months ago

[Tabs tray to Compose] Refactor the metrics out of `TabsTrayFragment`

Categories

(Fenix :: Tabs, task, P3)

All
Android
task

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: 007, Assigned: npoon)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group4])

Attachments

(1 file)

After Bug 1814993, the metric for presenting the inactive tabs auto close dialog was refactored to the fragment (in the XML version, this metric lives in InactiveTabsViewHolder). This metric should be refactored to live, ideally, in a middleware, otherwise into TabsTrayController for now.

As part of this ticket:

  • Create a TabsTrayTelemetryMiddleware
  • Create Actions for each of the lambda callbacks in TabsTrayFragment and perform the expected store dispatches.
  • Migrate the telemetry calls to the middleware.
  • Stand-up unit tests for the telemetry middleware.
Summary: [Tabs tray to Compose] Refactor the `onInactiveTabsAutoCloseDialogShown` metric out of `TabsTrayFragment` → [Tabs tray to Compose] Refactor the metrics out of `TabsTrayFragment`
Whiteboard: [fxdroid]
Duplicate of this bug: 1834843
Whiteboard: [fxdroid] → [fxdroid][group4]
Assignee: nobody → npoon
Status: NEW → ASSIGNED
Blocks: 1907088
Pushed by calu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aa88ca616a35 Refactor the metrics out of `TabsTrayFragment` r=android-reviewers,007
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: