Closed Bug 1826371 Opened 2 years ago Closed 2 years ago

Update Unified Search to depend on experiment flag instead of feature flag

Categories

(Fenix :: Toolbar, enhancement, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
enhancement

Tracking

(firefox111 wontfix, firefox112 fixed, firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox111 --- wontfix
firefox112 --- fixed
firefox113 --- fixed

People

(Reporter: royang, Assigned: royang)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

[mozilla-mobile/firefox-android] Bug 1826371 - Enable Unified Search feature (#1540)
59 bytes, text/x-github-pull-request
Details | Review
[mozilla-mobile/firefox-android] Bug 1826371 - Update Unified Search to depend on experiment flag instead of feature flag (backport #1540) (#1567)
59 bytes, text/x-github-pull-request
diannaS
: approval-mozilla-release+
Details | Review

Currently Unified Search is only enabled and with Nimbus flag set to true in Nightly and Debug. Update Unified Search feature flag to true or all channels but keeping Nimbus flag to false for beta and release.

Assignee: nobody → royang

We will want to uplift this fix to 112.

Severity: -- → N/A
status-firefox111: --- → affected
status-firefox112: --- → affected
status-firefox113: --- → affected
Priority: -- → P1
Summary: Enable Unified Search Feature → Update Unified Search to depend on experiment flag instead of feature flag
See Also: → 1826169
Authored by https://github.com/rocketsroger https://github.com/mozilla-mobile/firefox-android/commit/1e0e2205350a4f21a2efc8845289d162e256d717 [main] Bug 1826371 - Update Unified Search to depend on experiment flag instead of feature flag
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: affected → fixed
status-firefox113: affected → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Blocks: unified-search-ux-qa
Flags: qe-verify+

Please approve uplift for v112. Thanks

Flags: needinfo?(jmahon)

Yep, good to go.

Confirming here (mostly for my own future sanity) - the flag that's preventing Unified Search from showing up for everyone is here.

Flags: needinfo?(jmahon)

Comment on attachment 9326917 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826371 - Enable Unified Search feature (#1540)

Beta/Release Uplift Approval Request

  • User impact if declined: Experimentation with unified search feature can't be performed in v112.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The risk is low because the feature flag allows the Nimbus experiment to control the feature. This feature is off by default without experimentation.
  • String changes made/needed: None
  • Is Android affected?: Yes
Attachment #9326917 - Flags: approval-mozilla-beta?
Comment on attachment 9327187 [details] [review] [mozilla-mobile/firefox-android] Bug 1826371 - Update Unified Search to depend on experiment flag instead of feature flag (backport #1540) (#1567) Approved for 112.0rc2
Attachment #9327187 - Flags: approval-mozilla-release+
Attachment #9326917 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: