1826473 - [Unified Search] Remove topical search engines from search settings screen

Status: VERIFIED FIXED

(Firefox for Android :: Search, enhancement, P2)

Description

[Chris Peterson [:cpeterson]]

Bug 1804594 differentiated between general search engines (like Google) and topical search engines (like Amazon). We

As part of the unified search work, a change was made to not allow topical, pre-installed search engines be selected as a default. This results in some of the search engines being greyed out while others are able to be selected. This is confusing because it isn’t clear why those search engines appear disabled nor is there a way to have them become enabled.

The new UX will be designed in https://mozilla-hub.atlassian.net/browse/FXMUX-462

Comment 1

[Chris Peterson [:cpeterson]]

This bug blocks Unified Search MVP because PM and UX needs to decide whether we ship this current design, a new design, or revert to the old design.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

Screenshot of the current design with topical search engines (Amazon, eBay, and Wikipedia) greyed out.

We can't simply remove the topical search engines from this search settings screen because users would then not be able to delete them from the Unified Search menu.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826473 – add new search engine settings screens (#2274)

Comment 4

[Chris Peterson [:cpeterson]]

We'd like to fix this bug before we release Unified Search in 115. We don't need to uplift the fix to 114.

Comment 5

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/6fa2c0342c05648ef19ea57d875870e494d65fad
[main] Bug 1826473 – add new search engine settings screens

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do we need this on v115?

Comment 7

[Mike a [:mavduevskiy]]

yes, but after QA and UX QA verification.

Comment 8

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We'd like to enable the Unified Search UI (bug 1820018) in 115. To do see, we would to uplift this new search engine fix to Beta 115. We'll also want to uplift related bug 1837864 and bug 1838691.

Comment 9

[Donal Meehan [:dmeehan]]

:cpeterson 115.0b9 builds on Thursday, the final beta build of Fx115.
Is there anything preventing an uplift request on this before Thursday? (RE: mentions of verification in Comment 7)

Comment 10

[Chris Peterson [:cpeterson]]

I asked QA and the engineer about uplifting before Thursday. If we don't make Thursday's build, we will have to wait until a 115.x dot release or 116.

TBD whether we will still be able to enable the Unified Search UI in 115.0 if we don't have these fixes. Enabling Unified Search might need to wait until that 115.x dot release or 116.

Comment 11

[Delia Pop (Android QA)]

Attachment: SearchSettingsScreens.png

Verified as Fixed on Nightly 116.0a1 from 06/21. The Search Settings Screens are displayed as per the Figma design.
We ensured that:

• General search engines are displayed in the Default search engine sub-menu and an engine can be set as default search engine;
• Shortcuts for all the available search engines (general/topic-specific and custom engines) are displayed in the Manage search shortcuts sub-menu and can be selected/un-selected;
• The selected shortcuts in the Manage search shortcuts sub-menu are displayed accordingly in the vertical search menu;
• Custom search engines can be added from both sub-menus;

Devices used for testing:

• Samsung Galaxy A53 5G (Android 13)
• Google Pixel 4 (Android 13)
• Samsung Galaxy Tab S3 (Android 9)
• Lenovo Yoga Tab 11 (Android 11)

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1826473 – add new search engine settings screens (backport #2274) (#2569)

Comment 13

[Mike a [:mavduevskiy]]

Comment on attachment 9336560 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826473 – add new search engine settings screens (#2274)

Beta/Release Uplift Approval Request

• User impact if declined: Releasing 115 without it will result in confusing UX experience with search settings. The bug is part of the Unified search project, and UX team raised the issue of redoing search screens as a blocker for shipping the feature. Now, I am not sure if projects are on the same page about it being a blocker, but it definitely makes the user experience much better.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1838691, Bug 1837864
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's been in nightly for 9 days, is mostly UI changes and QA has verified it
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9336560 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826473 – add new search engine settings screens (#2274)

Moving the uplift request to the PR targeting the release branch

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9340367 [details] [review]
[mozilla-mobile/firefox-android] Bug 1826473 – add new search engine settings screens (backport #2274) (#2569)

Approved for Fenix 115.0b9.

Comment 16

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/b3e665b403811d38e7d93d158a70e2a25330b952
[releases_v115] Bug 1826473 – add new search engine settings screens (backport #2274) (#2569)

Comment 17

[Delia Pop (Android QA)]

Attachment: Screenshot_2023-06-23-12-34-14.png

Verified as Fixed on Beta 115.0b9 as well.
Devices used for testing:

• Huawei Mate 20 Lite(Android 10)
• Lenovo Tab P11 Plus (Android 12)
• Samsung Galaxy Note 8 (Android 9)
• Oppo Find X5 (Android 13)
• Huawei MediaPad M2 (Android 5.1.1)