1837864 - Search settings screen, fix visibility of the items in the list

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect, P3)

Description

[Mike a [:mavduevskiy]]

Steps to reproduce

precondition: unified search should be enabled

1. Open settings screen.
2. Navigate to search settings screen.

Expected behavior

A static list of items is displayed.

Actual behavior

The items in the list are animated, hiding the first element in the list in "address bar" broup.

Device information

• Firefox version: 115
• Android device model: pixel 7
• Android OS version: Android 13

Any additional information?

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837864 – fix search settings opening visual glitch (#2487)

Comment 2

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/9c46e7206db19b7eeac9f02c4e7b2aad1019c72a
[main] Bug 1837864 – fix search settings opening visual glitch

Comment 3

[Lorand Janos]

Managed to reproduce this issue with a previous Nightly 116.0a1 build (2023-06-15).
Verified as fixed on the latest Nightly 116.0a1 build (2023-06-16).
Devices used: Samsung Galaxy Tab S3 (Android 9) and Google Pixel 4 (Android 13).
Marking the ticket as verified.

Comment 4

[Chris Peterson [:cpeterson]]

Do we need to uplift this fix to Beta 115?

Comment 5

[Chris Peterson [:cpeterson]]

Mike says we'll want to uplift this fix to Beta 115 after uplifting bug 1826473.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837864 – fix search settings opening visual glitch (backport #2487) (#2571)

Comment 8

[Mike a [:mavduevskiy]]

Comment on attachment 9339371 [details] [review]
[mozilla-mobile/firefox-android] Bug 1837864 – fix search settings opening visual glitch (#2487)

Beta/Release Uplift Approval Request

• User impact if declined: There will be a minor visual glitch every time a search settings screen is opened.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): it changes only the lifecycle callback when the view visibility is set.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9339371 [details] [review]
[mozilla-mobile/firefox-android] Bug 1837864 – fix search settings opening visual glitch (#2487)

Moving the uplift request to the PR targeting the release branch

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9340369 [details] [review]
[mozilla-mobile/firefox-android] Bug 1837864 – fix search settings opening visual glitch (backport #2487) (#2571)

Approved for Fenix 115.0b9.

Comment 11

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/15e94f9ca9de103aeb438d56489ef823bbfdee78
[releases_v115] Bug 1837864 – fix search settings opening visual glitch

Comment 12

[Lorand Janos]

Verified as Fixed on Beta 115.0b9 as well.
Devices used for testing:

• Huawei Mate 20 Lite(Android 10)
• Lenovo Tab P11 Plus (Android 12)
• Samsung Galaxy Note 8 (Android 9)
• Oppo Find X5 (Android 13)
• Huawei MediaPad M2 (Android 5.1.1)