1826649 - Langpacks not loading in Flatpak build

Status: RESOLVED MOVED

(Thunderbird :: Preferences, defect, P2)

Description

[Melissa A [:melissa_a]]

Attachment: Language Modal displaying English (US), the dropdown for "Select a language to add" ends up empty.

The flatpak build displays an empty language selector with an option for English (US). On my main Thunderbird install (via www.thunderbird.net) it displays English (CA).

Additionally (And probably the main issue) I cannot add any additional language. I'm not sure if this is just a "This build" restriction, or I'm missing something. I click on "Select a language to add" and it shows an empty list with the header "Available Languages"

Happy to provide any additional details as needed.

Comment 1

[Rob Lemley [:rjl]]

It's worse than this..

The idea is to have a multi-language flatpak that includes all supported locales so users don't have to download/install anything additional.

It doesn't work.

1682449534676	addons.xpi	ERROR	Failed to install distribution add-on /app/lib/thunderbird/distribution/extensions/[e-mail]: Error: File /app/lib/thunderbird/distribution/extensions/[e-mail] does not contain a valid manifest(resource://gre/modules/addons/XPIInstall.jsm:684:11) JS Stack trace: [e-mail]:684:11
[e-mail]:226:15
[e-mail]:2967:35
[e-mail]:3080:22
[e-mail]:2528:12
[e-mail]:246:31
[e-mail]:554:17
[e-mail]:760:14
[e-mail]:3666:26
[e-mail]:75:29 Log.sys.mjs:722
    append resource://gre/modules/Log.sys.mjs:722
    log resource://gre/modules/Log.sys.mjs:376
    error resource://gre/modules/Log.sys.mjs:384
    installDistributionAddons resource://gre/modules/addons/XPIProvider.jsm:2987
    checkForChanges resource://gre/modules/addons/XPIProvider.jsm:3080
    startup resource://gre/modules/addons/XPIProvider.jsm:2528
    callProvider resource://gre/modules/AddonManager.jsm:246
    _startProvider resource://gre/modules/AddonManager.jsm:554
    startup resource://gre/modules/AddonManager.jsm:760
    startup resource://gre/modules/AddonManager.jsm:3666
    observe resource://gre/modules/addonManager.js:75

This message appears for every locale. This needs to be addressed prior to releasing on Flathub.

Comment 2

[Rob Lemley [:rjl]]

Ahh I think I see the problem.. Looks like there's the app flatpak and then a separate metadata.locale thing that has the langpacks.

We need to build-bundle the locales thing as well somehow for testing.

Comment 3

[Emerson Bernier]

Yes, flatpak locales are intentionally split. One thing I don't understand is why clicking on "Select a language to add" - > "Search for more languages" gives an empty list. In flathub's thunderbird (and firefox) searching for langs gives full list (fetched remotely) regardless of what langs are installed in flatpak. Did network worked in the test build?

Comment 4

[Rob Lemley [:rjl]]

(In reply to Emerson Bernier from comment #3)

Yes, flatpak locales are intentionally split. One thing I don't understand is why clicking on "Select a language to add" - > "Search for more languages" gives an empty list. In flathub's thunderbird (and firefox) searching for langs gives full list (fetched remotely) regardless of what langs are installed in flatpak. Did network worked in the test build?

This is a known problem with langpacks and Thunderbird beta builds. They are not published to addons.thunderbird.net, and are therefore not available for download within Thunderbird. Release builds of langpacks have to be manually uploaded.

Comment 5

[Rob Lemley [:rjl]]

(In reply to Rob Lemley [:rjl] from comment #4)

(In reply to Emerson Bernier from comment #3)

Yes, flatpak locales are intentionally split. One thing I don't understand is why clicking on "Select a language to add" - > "Search for more languages" gives an empty list. In flathub's thunderbird (and firefox) searching for langs gives full list (fetched remotely) regardless of what langs are installed in flatpak. Did network worked in the test build?

This is a known problem with langpacks and Thunderbird beta builds. They are not published to addons.thunderbird.net, and are therefore not available for download within Thunderbird. Release builds of langpacks have to be manually uploaded.

Beta langpacks will soon be uploaded to ATN automatically. Probably with 115beta4. I don't think that solves all of the problem with downloading though. Bug 1487315 needs to be implemented it looks like.

However, if the langpack flatpak is available this should not be (much) of an issue.

Comment 6

[Daniel Darnell [:dandarnell]]

Attachment: Screenshot from 2023-06-26 02-47-48.png

(In reply to Rob Lemley [:rjl] from comment #5)

(In reply to Rob Lemley [:rjl] from comment #4)

(In reply to Emerson Bernier from comment #3)

Yes, flatpak locales are intentionally split. One thing I don't understand is why clicking on "Select a language to add" - > "Search for more languages" gives an empty list. In flathub's thunderbird (and firefox) searching for langs gives full list (fetched remotely) regardless of what langs are installed in flatpak. Did network worked in the test build?

This is a known problem with langpacks and Thunderbird beta builds. They are not published to addons.thunderbird.net, and are therefore not available for download within Thunderbird. Release builds of langpacks have to be manually uploaded.

Beta langpacks will soon be uploaded to ATN automatically. Probably with 115beta4. I don't think that solves all of the problem with downloading though. Bug 1487315 needs to be implemented it looks like.

However, if the langpack flatpak is available this should not be (much) of an issue.

As of automatic langpack uploads landing, langpacks now appear to be working in the beta Thunderbird flatpak builds. I've tested this locally on my machine, and although langpacks still do not ship with the flatpak build of Thunderbird (mirroring how the Firefox flatpak does locales), they are now available to be added in settings.

I was able to install Japanese (among other langpacks) and set it as default without any issues.