1826747 - Create a per-"addon gated site permission" mapping table for 3rd party install and post install prompt localized string ids

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The SitePermission addon type has been going through a few rewording of the "3rd party install" and "post install" doorhanger to make it more clear to users what are they getting prompted for and what are the risks of accepting the "addon gated" SitePermissions install triggered from a website that the user is visiting.

At the moment midi and midi-sysex are the only two gated permissions supported, and so the localized string ids are currently hardcoded, but we would like to create an explicit per-"addon gated site permission" mapping table.

The new mapping table could be exported from the existing siteperms-addon-utils.sys.mjs ES module, which is also the ES module exporting other helpers related to the SitePermission addon type (e.g. in addition to the existing helpers function isGatedPermissionType or isPrincipalInSitePermissionsBlocklist we may introduce new ones like export function getInstallPromptStringIds(type) { ... } and export function getPermissionsPromptStringIds(type) { ... } to retrieve the string ids associated to a given sitepermission type string).

Comment 1

[Greg Stoll :gstoll]

Attachment: Bug 1826747 - Create table for site permission add-on strings r=#extension-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1e5310f4f558
https://hg.mozilla.org/integration/autoland/rev/c1294365259d
Create table for site permission add-on strings r=rpl

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c1294365259d