1826838 - firefox-android: port lint tasks to oak/mozilla-central

Status: RESOLVED FIXED

(Release Engineering :: General, task)

Description

[Geoff Brown [:gbrown]]

There are 5 lint kinds on firefox-android, each of which are run against AC, focus, and fenix.

• buildconfig
• compare-locales
• detekt
• ktlint
• lint

There is a compare-locales mach command on central, but that looks different.

There is an android-lint task (mozlint-android kind) on central, for geckoview, which runs multiple linters:

• android-api-lint
• android-format
• android-javadoc
• android-checkstyle
• android-lint
• android-test

Comment 1

[Geoff Brown [:gbrown]]

It seems like we shouldn't just port the tasks, but integrate with the linting system, so 'mach lint' knows about the new linters also:
https://firefox-source-docs.mozilla.org/code-quality/lint/create.html

Comment 2

[Julien Cristau [:jcristau]]

Attachment: WIP: Bug 1826838 - skip desktop tasks on oak

Comment 3

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - add nightly-android target tasks method and cron job

Comment 4

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - Update comments in android-components Dockerfile

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - migrate firefox-android lint/detekt tasks

Comment 6

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - migrate ktlint tasks from firefox-android

Comment 7

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - migrate firefox-android's lint/lint tasks

Comment 8

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - firefox-android lints are all migrated, remove old kind.yml

Comment 9

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - fix android-lint task-defaults

Comment 10

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - pass --break-system-packages to pip install

Comment 11

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - run mach build in android buildconfig lint task

• remove pygit2 from the requirements, no longer necessary now we're on
  mercurial
• configure isn't enough, the gradle dependencies tasks error out if
  they can't find geckoview, so add a build step

Comment 12

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - add m4 to lint docker image

fixes regression from bug 1877349

Comment 13

[Phabricator Automation]

Comment on attachment 9379507 [details]
Bug 1826838 - add nightly-android target tasks method and cron job

Revision D201391 was moved to bug 1876318. Setting attachment 9379507 [details] to obsolete.

Comment 14

[Julien Cristau [:jcristau]]

Attachment: Bug 1826838 - remove pygit2 from android buildconfig pip requirements. r=bhearsum

No longer necessary now we're on mercurial.

Comment 15

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/mozilla-central/rev/77b0cb7f8223
https://hg.mozilla.org/mozilla-central/rev/b68f7a862fc9
https://hg.mozilla.org/mozilla-central/rev/d0fdfe8146bf
https://hg.mozilla.org/mozilla-central/rev/12b406f60f36
https://hg.mozilla.org/mozilla-central/rev/988965c0f81c
https://hg.mozilla.org/mozilla-central/rev/ae0130cd8b6b
https://hg.mozilla.org/mozilla-central/rev/9ecf3f242f5a
https://hg.mozilla.org/mozilla-central/rev/9d3a0d4d3942