Closed Bug 1827146 Opened 2 years ago Closed 7 months ago

SeaMonkey Composer adds moz-do-not-send attribute for links and images

Categories

(SeaMonkey :: Composer, defect)

SeaMonkey 2.53
defect

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: abo.pignard, Assigned: frg)

References

(Regression)

Details

(Keywords: regression, Whiteboard: SM2.53.21)

Attachments

(1 file)

Steps to reproduce:

I create a link in an HTLM page.

Actual results:

The added source HTML code is:
<a href="liens_histo.html#nvu" moz-do-not-send="true">Nvu</a>

Expected results:

The attribute moz-do-not-send="true" shouldn't be added to the link.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: SeaMonkey 2.53 Branch → Trunk

[Approval Request Comment]
Regression caused by (bug #): Bug 1686845
User impact if declined: bad html for links and images generated in composer
Testing completed (on m-c, etc.): 2.53.21b1 pre
Risk to taking this patch (and alternatives if risky): mostly trivial. cases mail, composer and debugQA composer tested
String changes made by this patch: --

Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #9477336 - Flags: review?(nunojsg)
Attachment #9477336 - Flags: review?(iannbugzilla)
Attachment #9477336 - Flags: approval-comm-release?
Summary: Composer adds moz-do-not-send attribute in links. → SeaMonkey Composer adds moz-do-not-send attribute for links and images
Whiteboard: SM2.53.21
Version: Trunk → SeaMonkey 2.53 Branch
Duplicate of this bug: 1833236

Comment on attachment 9477336 [details] [diff] [review]
1827146-moz-do-not-send-25321.patch

[Triage Comment]
LGTM r/a=me

Attachment #9477336 - Flags: review?(iannbugzilla)
Attachment #9477336 - Flags: review+
Attachment #9477336 - Flags: approval-comm-release?
Attachment #9477336 - Flags: approval-comm-release+
Keywords: regression
Regressed by: 1686845

Comment on attachment 9477336 [details] [diff] [review]
1827146-moz-do-not-send-25321.patch

lgtm

Attachment #9477336 - Flags: review?(nunojsg) → review+
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/0d9228cc6c96108e0c28709e0d0d05500fc95d77
Do not set moz-do-not-send for images and links in composer. r=IanN,njsg a=IanN

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: