Picture-in-Picture window has no decorations with mwm
Categories
(Toolkit :: Picture-in-Picture, defect, P3)
Tracking
()
People
(Reporter: naddy, Unassigned)
References
(Regression)
Details
(Keywords: regression)
User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:109.0) Gecko/20100101 Firefox/112.0
Steps to reproduce:
On an X11 desktop using the Motif Window Manager (mwm), play a YouTube video with Firefox 112 and use a Picture-in-Picture window.
Actual results:
The PiP window has no window decorations, e.g. no titlebar. As a result it cannot be moved or resized.
Expected results:
Up to and including Firefox 111, the PiP had normal window decorations.
|
||
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•2 years ago
|
||
Hmm. There was briefly a change in 112 beta (bug 1823350) that might have caused something like this, but that was backed out prior to 112 leaving beta, so I don't think I have any ideas. Emilio, do you know of anything that might have happened here?
|
||
Comment 3•2 years ago
|
||
Possibly bug 1794577? Is there any chance you could run mozregression so we know what broke it in your setup? Though PiP windows were intended to always be undecorated...
$ pip install --user mozregression
$ mozregression --good 111 --bad 112 -a https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4
Should allow you to find the offending commit in hopefully not more than 10 mins or so :)
|
Reporter | |
Comment 4•2 years ago
|
||
I'm not on Linux and can't run pre-built nightlies, so mozregression is a nonstarter.
|
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 5•2 years ago
|
||
I can now confirm that the problem was introduced by this commit:
Bug 1794577 - Clear decorations from PiP window earlier during creation.
https://hg.mozilla.org/mozilla-central/rev/bcea4f6871b4
|
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 6•1 year ago
|
||
It has become clear that the lack of window decorations for the PiP window is intentional. That much is already obvious from the code changes. The PiP window also has its own resizing controls. And I'm told that with some window managers it is also possible to move it. I do not understand this confusing design decision, but it is what it is.
Description
•