1823350 - "Always on top" DevTools windows don't have window decorations on Wayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Go to about:debugging > This nightly.
• Click "Inspect" on one extension.

ER: A window with decorations.
AR: No close/minimize/maximize windows.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1823350 - Unify how we identify PiP windows on Linux/Windows. r=mconley!,stransky!

Also explicitly use titlebar=no on the PIP window, since we really don't
want a titlebar.

This way we don't end up without titlebars in other alwaysontop windows.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9125aacdb96b
Unify how we identify PiP windows on Linux/Windows. r=mconley,stransky

Comment 4

[Marian-Vasile Laza]

Backed out changeset 9125aacdb96b (Bug 1823350) for bc failures on browser_changePiPSrcInFullscreen.js.
Backout link
Push with failures <--> bc1
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1733deee7bd
Unify how we identify PiP windows on Linux/Windows. r=mconley,stransky

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e1733deee7bd

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9323896 [details]
Bug 1823350 - Unify how we identify PiP windows on Linux/Windows. r=mconley!,stransky!

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0, but also we should test that PiP windows don't regress unexpectedly.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tweaks PiP setup a little bit but should be a reasonably safe change.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9323896 [details]
Bug 1823350 - Unify how we identify PiP windows on Linux/Windows. r=mconley!,stransky!

Approved for 112.0b6

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f97098eac3e5

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Grr, let's back out from beta for causing bug 1824165. We can re-uplift if the fix is trivial or so I suppose (though maybe not worth it since the only firefox UI that we know it's affected is hard-ish to reach).

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Hmm, we probably can come up with a simple fix...

Comment 13

[Mike Conley (:mconley) (:⚙️)]

I have something upliftable in bug 1824165 - I'll go ahead and request uplift.

Comment 14

[Monica Chiorean]

Reproduced the issue on Ubuntu 20.04 using FF snap build 111.0.1(20230321162322).
Verified as fixed on Ubuntu 20.04 using FF build 113.0a1(20230324092024) and Beta 112.0b6(20230223181038). Issue is not reproducing on Win10/Mac10.13.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Let's backout this from beta please. It caused other issues on Linux like bug 1824304 which probably need a bit of a rethink.

Comment 16

[Dianna Smith [:diannaS]]

sounds good, ill backout this and bug 1824165 on the next beta push

Comment 17

[Dianna Smith [:diannaS]]

Backed out changeset f97098eac3e5 (Bug 1823350) from beta for causing Bug 1824304
Backout : https://hg.mozilla.org/releases/mozilla-beta/rev/835cfdafcd26