Make tabs.create() compatible with Firefox
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
People
(Reporter: tdulcet, Assigned: TbSync)
References
Details
(Whiteboard: [snnot3p])
Attachments
(4 files, 3 obsolete files)
This bug was created at the request of John in bug 1716200:
(In reply to John Bieling (:TbSync) from comment #17)
Currently in the latest TB Daily, tabs.create() with an arbitrary URI just opens a blank tab and does not prompt the user to open their external application.
Hm. I think that does not work, because it triggers the overlay prompter and not the dialog prompter. That needs a new bug.
Bug 1716200 should fix the tabs.update() function to be compatible with Firefox and support opening arbitrary URIs, but the tabs.create() function still does not work as expected. With an arbitrary URI, it just opens a blank tab and does not prompt the user to open their external application.
For some context, with my Link Creator add-on, users can select text to open unlinked URIs, URLs, email addresses, telephone numbers, etc. After bug 1716200 lands, it will be able to use tabs.update() when opening a single arbitrary URI, but it still needs tabs.create() so it can open multiple arbitrary URIs. Bug 1828102 will also be needed to open mailto: URIs.
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
Marking as [snnot] per John's information. 20230419_1545
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D199213
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 4•1 year ago
|
||
We already have a test which verifies the correct urls being handled,
that however is using a mock of nsIExternalProtocolService. This test
verifies that the application chooser dialog is actually opened.
Depends on D199219
|
|
Assignee | |
Comment 5•1 year ago
|
||
Depends on D199219
|
|
Assignee | |
Comment 6•1 year ago
|
||
Depends on D200918
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 7•1 year ago
|
||
This adds a missing test for opening registered WebExtension protocol
handler pages in a popup window.
Depends on D199219
|
|
Assignee | |
Comment 8•1 year ago
|
||
This adds missing tests for opening non-registered WebExtension protocol
handler pages and other pages which have to be handled externally in a popup window.
This also renames the changed test file to indicate, that these tests
use a mocked nsIExternalProtocolHandler.
Depends on D200922
|
|
Assignee | |
Comment 9•1 year ago
|
||
We already have a test which verifies the correct urls being handled,
that however is using a mock of nsIExternalProtocolService. This test
verifies that the application chooser dialog is actually opened.
Depends on D200923
|
|
Assignee | |
Comment 10•1 year ago
|
||
Summary: This reported bug is fixed by Bug 1875460. I use this bug to add tests to ensure the correct behavior.
|
|
Assignee | |
Updated•11 months ago
|
|
||
Updated•11 months ago
|
|
||
Comment 11•11 months ago
|
||
Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/0b7f8516204f
Add test for creating tabs with externally handled urls. r=#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/ae33e7907af0
Add test for opening popup windows with WebExtension protocol handler urls. r=#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/5b1c1d61123f
Add tests for opening popup windows with externally handled urls. r=#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/562a1b98cfb6
Add test to verify the application chooser dialog is correctly opened. r=#thunderbird-reviewers
Description
•