Closed Bug 1828573 Opened 1 year ago Closed 8 months ago

Move away from JSX

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: nchevobbe, Assigned: bomsy)

References

Details

Attachments

(11 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Having JSX means we need to transpile the code, which leads to different code , making it a bit harder to debug.
Also this makes the quick reload feature not working, so you always need to run mach build faster each time you make changes in the debugger
Finally, this is the only panel where we use jsx, so removing it would make the devtools codebase more consistent

Assignee: nobody → hmanilla
Attachment #9345265 - Attachment description: WIP: Bug 1828573 - [devtools] Convert the base components in the debugger → Bug 1828573 - [devtools] Converts the base components in the debugger from jsx r=#devtools-reviewers
Status: NEW → ASSIGNED
Attachment #9347587 - Attachment is obsolete: true
Keywords: leave-open
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6699b33d298
[devtools] Converts the base components in the debugger from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/329bd8bf1c69
[devtools] Convert the primary panes components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8e0997180630
[devtools] Converts shared button components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ec0d8fea440a
[devtools] Converts the rest of the debugger shared components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/de0e3f54955c
[devtools] Convert Preview components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/25988846b298
[devtools] Convert the editor components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8036d6b06dc6
[devtools] Convert the breakpoint list components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f33490847077
[devtools] Convert the Frame components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ceee5818d1a1
[devtools] Convert the rest of the Secondary panel components from jsx r=devtools-reviewers,nchevobbe
Keywords: leave-open
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05f4560ba4c9
[devtools] Convert all component jest tests from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6c4376d088c8
[devtools] Remove the jsx plugin from the build script r=devtools-reviewers,nchevobbe

== Change summary for alert #39238 (as of Tue, 08 Aug 2023 22:59:11 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
59% damp custom.jsdebugger.pause.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 328.54 -> 520.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39238

Regressions: 1862022
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: