1828573 - Move away from JSX

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Having JSX means we need to transpile the code, which leads to different code , making it a bit harder to debug.
Also this makes the quick reload feature not working, so you always need to run mach build faster each time you make changes in the debugger
Finally, this is the only panel where we use jsx, so removing it would make the devtools codebase more consistent

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Converts the base components in the debugger from jsx r=#devtools-reviewers

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the primary panes components from jsx r=#devtools-reviewers

Depends on D184326

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Converts shared button components from jsx r=#devtools-reviewers

Depends on D184327

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Converts the rest of the debugger shared components from jsx r=#devtools-reviewers

Depends on D184887

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert Preview components from jsx r=#devtools-reviewers

Depends on D184888

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the editor components from jsx r=#devtools-reviewers

Depends on D184889

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the breakpoint list components from jsx r=#devtools-reviewers

Depends on D184890

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the Frame components from jsx r=#devtools-reviewers

Depends on D184935

Comment 9

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the rest of the Secondary panel components from jsx r=#devtools-reviewers

Depends on D184936

Comment 10

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Remove the jsx plugin from the build script r=#devtools-reviewers

Comment 11

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert the rest of the Secondary panel components from jsx r=#devtools-reviewers

Comment 12

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1828573 - [devtools] Convert all component jest tests from jsx r=#devtools-reviewers

Depends on D184937

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6699b33d298
[devtools] Converts the base components in the debugger from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/329bd8bf1c69
[devtools] Convert the primary panes components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8e0997180630
[devtools] Converts shared button components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ec0d8fea440a
[devtools] Converts the rest of the debugger shared components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/de0e3f54955c
[devtools] Convert Preview components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/25988846b298
[devtools] Convert the editor components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8036d6b06dc6
[devtools] Convert the breakpoint list components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f33490847077
[devtools] Convert the Frame components from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ceee5818d1a1
[devtools] Convert the rest of the Secondary panel components from jsx r=devtools-reviewers,nchevobbe

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05f4560ba4c9
[devtools] Convert all component jest tests from jsx r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6c4376d088c8
[devtools] Remove the jsx plugin from the build script r=devtools-reviewers,nchevobbe

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d6699b33d298
https://hg.mozilla.org/mozilla-central/rev/329bd8bf1c69
https://hg.mozilla.org/mozilla-central/rev/8e0997180630
https://hg.mozilla.org/mozilla-central/rev/ec0d8fea440a
https://hg.mozilla.org/mozilla-central/rev/de0e3f54955c
https://hg.mozilla.org/mozilla-central/rev/25988846b298
https://hg.mozilla.org/mozilla-central/rev/8036d6b06dc6
https://hg.mozilla.org/mozilla-central/rev/f33490847077
https://hg.mozilla.org/mozilla-central/rev/ceee5818d1a1
https://hg.mozilla.org/mozilla-central/rev/05f4560ba4c9
https://hg.mozilla.org/mozilla-central/rev/6c4376d088c8

Comment 16

[Julian Descottes [:jdescottes]]

== Change summary for alert #39238 (as of Tue, 08 Aug 2023 22:59:11 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
59%	damp custom.jsdebugger.pause.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	328.54 -> 520.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39238