1862022 - Quick search panel item aren't scrolled into view when navigating with the arrow keys

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the debugger
3. Open the quick search panel with Ctrl+P (Cmd+P on OSX)
4. Type _ so the list gets populated with lots of items
5. Press the arrow down key until the list should scroll to be in sync with the selected element

Expected results

The list scrolls so the selected item is always visible

Actual results

The list doesn't scroll

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

ESR 115 is not impacted
Firefox 119 is impacted

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f4f211db29dd3b8d9a15bdede2a23dc22033af73&tochange=ceee5818d1a1583bd3276eb5ba29174f53644028

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1828573

:bomsy, since you are the author of the regressor, bug 1828573, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1862022 - [devtools] Fix the scroll issue in the quickopen panel r=#devtools-reviewers

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1828573

Comment 6

[Donal Meehan [:dmeehan]]

Too late for Fx122, :bomsy do you plan on landing the attached patch anytime soon?
Wondering if something will land in time for Fx123

Comment 7

[Hubert Boma Manilla (:bomsy)]

Thanks for reaching out .. Donal.

I'm looking to try to get this landed for Fx123.

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: WIP: Bug 1862022 - [devtools] Add test cover auto scrolling when pressing the up/down arrows to move through the list of items

The complexity of this test is that when doing pressKey(dbg, "Down");, programatically the scroll changes are not tracked e.g scrollTop is still allways 0 (until el.scrollIntoView() is called)
even though the UI visually scrolls.

Depends on D193721

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8456ea9fb109
[devtools] Fix the scroll issue in the quickopen panel r=devtools-reviewers,nchevobbe

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8456ea9fb109

Comment 11

[Dianna Smith [:diannaS]]

:bomsy can you mark this as fixed for 123 and move the test to a new bug?

Comment 12

[Phabricator Automation]

Comment on attachment 9372473 [details]
WIP: Bug 1862022 - [devtools] Add test cover auto scrolling when pressing the up/down arrows to move through the list of items

Revision D198377 was moved to bug 1884326. Setting attachment 9372473 [details] to obsolete.