1828674 - Match to auto state when popover attribute is empty string

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[zsun]

https://html.spec.whatwg.org/#the-popover-attribute

Comment 1

[zsun]

Attachment: Bug 1828674 - Match to auto state when popover attribute is empty string. r=emilio

The original code matches the empty string to Manual instead.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1828674: part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1828674: part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio

Depends on D177763

Comment 4

[alexander :surkov (:asurkov)]

marking as blocking 1821732 because popover-light-dismiss.html all depends on popover empty value attribute

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a526004408c1
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ccfe4902760f
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a526004408c1
part 1) Add TODO to statically assert EnumTables shouldn't contain
duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ccfe4902760f
part 2) Set a popover's state to auto when the corresponding attribute value
is the empty string. r=emilio

Sorry, this likely will get backed out, because a test meta file needs to be changed. Got the fix locally.

Comment 7

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d7ab8a0f4d3ea22787e73d2a9277d885cfe9fa38

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f7322b59dfb
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/40ab13fb03c1
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing build bustage on nsGenericHTMLElement.cpp

Backout link

Push with failures

Failure log

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

Looking into it. Same error didn't occur locally.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9affc49af93c
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a357c4a1605c
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9affc49af93c
https://hg.mozilla.org/mozilla-central/rev/a357c4a1605c