Closed Bug 1828674 Opened 10 months ago Closed 10 months ago

Match to auto state when popover attribute is empty string

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: zsun, Assigned: mbrodesser-Igalia)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

The original code matches the empty string to Manual instead.

Assignee: nobody → zsun
Status: NEW → ASSIGNED
Blocks: popover
Blocks: 1828903
Severity: -- → S3
Assignee: zsun → mbrodesser
Blocks: 1832554

marking as blocking 1821732 because popover-light-dismiss.html all depends on popover empty value attribute

Blocks: 1821732
Pushed by mbrodesser@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/a526004408c1
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ccfe4902760f
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio
Attachment #9329069 - Attachment is obsolete: true

(In reply to Pulsebot from comment #5)

Pushed by mbrodesser@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/a526004408c1
part 1) Add TODO to statically assert EnumTables shouldn't contain
duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ccfe4902760f
part 2) Set a popover's state to auto when the corresponding attribute value
is the empty string. r=emilio

Sorry, this likely will get backed out, because a test meta file needs to be changed. Got the fix locally.

Flags: needinfo?(mbrodesser)
Flags: needinfo?(mbrodesser)
Pushed by mbrodesser@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/1f7322b59dfb
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/40ab13fb03c1
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio

Backed out for causing build bustage on nsGenericHTMLElement.cpp

Backout link

Push with failures

Failure log

Flags: needinfo?(mbrodesser)

Looking into it. Same error didn't occur locally.

Pushed by mbrodesser@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/9affc49af93c
part 1) Add TODO to statically assert `EnumTable`s shouldn't contain duplicate values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a357c4a1605c
part 2) Set a popover's state to auto when the corresponding attribute value is the empty string. r=emilio
Flags: needinfo?(mbrodesser)
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.