1828684 - [Tabs tray to Compose] Investigate tabs tray selected text style

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, task, P3)

Description

[Alexandru Putanu [:aputanu]]

Attachment: left: current default style, right: intended `Header20TextStyle`

In the Metropolis font removal, we modified the tabs tray "[number_of_tabs] selected" text to use the Header20TextStyle style, however, due to a syntax mistake, it used the default text style. For the composed tabs tray, what style should be used for this text? in FenixTypography we have headline6 which uses 500 weight and 20sp size, the same as Header20TextStyle

Comment 1

[Mike a [:mavduevskiy]]

:007
It's in the fxdroid whiteboard, but isn't it a task for the UX team? It sits inside our TODO list, but we don't have designers on that project, right? Should we move it somewhere for better visibility?

Comment 2

[Noah Bond [:007]]

:mavduekskiy

I'd argue it's not a UX task, specifically, since we don't need a full spec from them or need a entirely new design component created. This will be something that just needs a text style confirmation, which doesn't need the admin juggle of having them manage this ticket on one of their tracking boards. Whoever picks this task up will just need to work with UX/Design to figure out the text style and update the text in question.

Comment 3

[Mike a [:mavduevskiy]]

:007
agreed! thanks for the clarification :)

Comment 4

[Vlad Dreghici [:vdreghici]]

After discussing with UX, the decision to change this to Header20TextStyle has been made which is equivalent to headline6 (size 20, weight 500).

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1828684 - Update font style for number of selected tabs text (#2373)

Comment 6

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/9f00418f9278f0912bdd5e978bf43fc40f070633
[main] Bug 1828684 - Update font style for number of selected tabs text

Comment 7

[Delia Pop (Android QA)]

Attachment: selected text style.png

Verified as fixed on the latest Nightly 116.0a1 from 06/16 with the “Enable Tabs Tray to Compose rewrite” toggle ON.
Devices used:

• Samsung Galaxy A53 5G (Android 13)
• Lenovo Yoga Tab 11 (Android 11)
  Marking the ticket as verified.