1816522 - [Tabs tray to Compose] Add multi selection banner UI

Status: RESOLVED FIXED

(Fenix :: Tabs, task, P3)

Description

[Noah Bond [:007]]

When the Tabs Tray is multi select mode, the page indicator UI should be replaced by the multi selection banner. The close, "X", button should be plumbed with its logic (i.e. returning to the page indicator banner) with this story. The number of tabs selected should also be functioning after this ticket.

In the present XML version, the UI lives across TabsTrayFragment, components_tabstray2.xml, and SelectionBannerBinding.

Have placeholder click lambdas for the icon buttons.

Add

• "X selected" UI with correct number of selected tabs
• Icons for bookmark & share & three-dot

Bookmark, share, and three dot menu functionality will be handled in

• Bug 1816555
• Bug 1816556
• Bug 1816558

Comment 1

[Noah Bond [:007]]

Attachment: Screenshot 2023-02-13 at 12.32.31 PM.png

Comment 2

[Alexandru Putanu [:aputanu]]

Note from Jonathan: We should consider making the MultiSelectBanner to support different options in case we'd like to add the selection functionality to Private or Synced tabs at a future time.

Comment 3

[Noah Bond [:007]]

(In reply to Alexandru Putanu [:aputanu] from comment #2)

Note from Jonathan: We should consider making the MultiSelectBanner to support different options in case we'd like to add the selection functionality to Private or Synced tabs at a future time.

I think this makes sense. I would just caution against over-engineering anything from the beginning, as this will be fairly simple to refactor in the future, compared to the XML counterpart.

We also don't know yet what this could hypothetically look like, so any work we do today to try to accommodate potential use cases could also need to be refactored anyway to support the actual ask from product/UX down the road.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1816522 - Add multi selection banner UI (#1590)

Comment 5

[BMO Github Automation]

Authored by https://github.com/Alexandru2909
https://github.com/mozilla-mobile/firefox-android/commit/3f621ed7a10418a48e0a4a757dd5a45e125b2b6b
[main] Bug 1816522 - Add multi selection banner UI