1828879 - Incorrect overlay scrollbar position in RTL-direction container

Status: VERIFIED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Antwan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Display a container with direction set to RTL, with a vertical scrollbar, e.g.

https://bug720046.bmoattachments.org/attachment.cgi?id=590389
(using the first div).

Actual results:

Scrollbar is displayed on the left side of container

Expected results:

Scrollbar is displayed on the left side of container, but offset by a scrollbar width.

Comment 1

[Antwan]

Attachment: firefox112.png

Comment 2

[Antwan]

Attachment: firefox113.png

Comment 3

[Antwan]

Simplified test case:

https://jsfiddle.net/fct2ueyL/

Comment 4

[Antwan]

[Tracking Requested - why for this release]:

Comment 5

[Antwan]

This is a regression from firefox112, now occurring in firefox113

Comment 6

[Timothy Nikkel (:tnikkel)]

Hmm, I wasn't able to reproduce. I tested in nightly 2023-01-01, 2023-01-15, 2023-02-01, 2023-02-15, 2023-03-01, 2023-03-15, 2023-04-01, 2023-04-15. As well as in the latest 113 beta.

There's probably some setting I'm not changing that you have? Maybe a system language or rtl setting? Can you reproduce in a fresh profile or on another machine?

Comment 7

[Antwan]

Same with a fresh profile.

Hardware: MBP 16" 2021
OS: MacOS Ventura (version 13.3.1 (22E261))

Same with https://live.browserstack.com with any recent Macos version + Firefox 113.

Comment 8

[Antwan]

Attachment: Fresh profile + firefox113

Comment 9

[Timothy Nikkel (:tnikkel)]

Ah! I know what the difference is now. I have always show scrollbars on. Switching that back to overlay scrollbars and I can reproduce.

Regression range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6b6e5626e9594a9c03529e0a1dd34edb5df61ca9&tochange=5ab63cda14e846592345a2dda12709f65bd0c6ec

Comment 10

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Very annoying regression for RTL users. There's a workaround on non-Android platforms (turn off overlay scrollbars), but it'd be unfortunate to ship this.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824236

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1828879 - Fix position of RTL vertical overlay scrollbars. r=tnikkel,#layout

It was just a silly mistake. In the rtl case the position is already the
start, we don't need to move it into the box.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8f04b5bde7f
Fix position of RTL vertical overlay scrollbars. r=tnikkel,layout-reviewers

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c8f04b5bde7f

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9329854 [details]
Bug 1828879 - Fix position of RTL vertical overlay scrollbars. r=tnikkel,#layout

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial change.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329854 [details]
Bug 1828879 - Fix position of RTL vertical overlay scrollbars. r=tnikkel,#layout

Approved for 113.0b8.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0fbadffdc02d

Comment 19

[Anca Soncutean, Desktop QA]

Reproduced with Fx 114.0a1 (2023-04-19) on macOS 13.3.
Verified fixed with Fx 114.0a1 (2023-04-25) and Fx 113.0b8 on macOS 13.3.