1830276 - Perma bugs/1828879-1.html == bugs/1828879-1-ref.html | image comparison, max difference: 2, number of differing pixels: 12 when Gecko 114 merges to Beta on 2023-05-08

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central-as-beta-simulation
How to run these simulations
Failure log
Log snippet:

[task 2023-04-27T11:32:17.664Z] 11:32:17     INFO - REFTEST TEST-LOAD | file:///opt/worker/tasks/task_168259427323866/build/tests/reftest/tests/layout/reftests/bugs/1828879-1-ref.html | 2073 / 2074 (99%)
[task 2023-04-27T11:32:17.975Z] 11:32:17     INFO - REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/1828879-1.html == layout/reftests/bugs/1828879-1-ref.html | image comparison, max difference: 2, number of differing pixels: 12
[task 2023-04-27T11:32:17.975Z] 11:32:17     INFO - REFTEST   IMAGE 1 (TEST): data:image/png;base64,
[task 2023-04-27T11:32:17.975Z] 11:32:17     INFO - REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,
[task 2023-04-27T11:32:17.975Z] 11:32:17     INFO - REFTEST INFO | Saved log: START file:///opt/worker/tasks/task_168259427323866/build/tests/reftest/tests/layout/reftests/bugs/1828879-1.html
[task 2023-04-27T11:32:17.976Z] 11:32:17     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2023-04-27T11:32:17.976Z] 11:32:17     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2023-04-27T11:32:17.977Z] 11:32:17     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2023-04-27T11:32:17.977Z] 11:32:17     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2023-04-27T11:32:17.977Z] 11:32:17     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2023-04-27T11:32:17.978Z] 11:32:17     INFO - REFTEST INFO | Saved log: START file:///opt/worker/tasks/task_168259427323866/build/tests/reftest/tests/layout/reftests/bugs/1828879-1-ref.html
[task 2023-04-27T11:32:17.978Z] 11:32:17     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2023-04-27T11:32:17.978Z] 11:32:17     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2023-04-27T11:32:17.979Z] 11:32:17     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2023-04-27T11:32:17.979Z] 11:32:17     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2023-04-27T11:32:17.979Z] 11:32:17     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2023-04-27T11:32:17.979Z] 11:32:17     INFO - REFTEST TEST-END | layout/reftests/bugs/1828879-1.html == layout/reftests/bugs/1828879-1-ref.html

Comment 1

[Timothy Nikkel (:tnikkel)]

That test was actually added in bug 1829769.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Actually bug 1829769 added the test. Tim, it seems just a minor fuzz adjustment, but maybe given we have the more explicit test we can remove the fuzzy/hacky one? Either way tho.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1830276. Adjust fuzz on layout/reftests/bugs/1828879-1.html. r?#layout-reviewers

Comment 4

[Timothy Nikkel (:tnikkel)]

I think it's good to test the visual rendering as well as the computed rects.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a900eae0ac82
Adjust fuzz on layout/reftests/bugs/1828879-1.html. r=emilio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a900eae0ac82

Comment 7

[Noemi Erli[:noemi_erli]]

Verified in today's beta-simulation push