1829137 - "Password Required - Mozilla Firefox" popup has additional white line at the bottom with dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: password-popup.png

Found in

• Firefox 113.0b5

Affected versions

• Firefox 113.0b5
• Firefox 112.0.1
• Firefox 114.0a1

Tested platforms

• Affected platforms: Windows 10,
• Unaffected platforms: Ubuntu 22, macOS 12

Preconditions

• Enable Dark theme from Add-ons and themes.
• Have a Firefox profile with at least one saved login.
• Have a Primary Password set.

Steps to reproduce

1. Launch Firefox with preconditions.
2. Click the Firefox menu and select the "Passwords" option.
3. Trigger the "Password Required - Mozilla Firefox" popup, with editing a saved login.

Expected result

• The popup looks as expected.

Actual result

• The bottom part of the "Password Required - Mozilla Firefox" popup has additional white line using dark theme.

Regression range

• I will come back with regression range ASAP.

Comment 1

[Alice0775 White]

Attachment: image.png

I can reproduce the issue on Windows10.

Note:
This issue does not occur if HWA off.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2c05658add65ba2f7513b2a76fe32be80c7c86e6&tochange=1432fd8955ce7ee78eab40753eb15ee274045919

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810614

:emilio, since you are the author of the regressor, bug 1810614, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is a similar issue as bug 1620575... We have a fractional size, we ceil, and we leave one pixel behind...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1829137 - When sizing to content, ceil to CSS pixels. r=dholbert,jfkthame

Much like in bug 1620575. The front-end works with sizing in int CSS
pixels, so size to that so that there isn't a mismatch between our size
and the window size.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810614

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64d01c59d68d
When sizing to content, ceil to CSS pixels. r=dholbert

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/64d01c59d68d

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Tested on Windows 10 with Firefox 115.0b2 and Firefox 116.0a1, I can confirm this issue is fixed, verified that nothing was broken on this area, on Ubuntu 22 and macOS 10.15.