1847543 - Scrollbars showing in CanvasBlocker's browserAction popup on first click of every new session

Status: RESOLVED MOVED

(WebExtensions :: Developer Outreach, defect, P3)

Description

[aoia7rz7l]

Tested on 115.0.3 and 115.1.0esr on Windows.

STR:

1. Install canvasblocker-1.9.xpi from the AMO.
2. Move CanvasBlocker's browserAction into the navbar.
3. (Optionally) allow CanvasBlocker to run in Private Windows.
4. Restart Firefox.
5. Click on CanvasBlocker's browserAction.

Expected Behavior:

No scrollbars shown in CanvasBlocker's browserAction popup.

Actual Behavior:

Both vertical and horizontal scrollbars were shown in CanvasBlocker's browserAction popup when it is opened for the first time in the same session. This is not reproducible on subsequent clicks, even when you open a new window. Scrollbars can however be shown for a "second" time, when you open a new private window and click on CanvasBlocker's browserAction in that window, but again this is not reproducible on subsequent clicks, and even after you closed all private windows.

On Windows the scrollbars persist until you close the browserAction popup. On Linux however the scrollbars will only be visible for a split second and then disappear, but you do sometimes get the same behavior as Windows. You can flip widget.gtk.overlay-scrollbars.enabled to false and widget.non-native-theme.scrollbar.style to 4 to make this slightly more noticeable on Linux.

Mozregression returned

Last good revision: f9836204ac87c171b1a17d321288358680019a5a
First bad revision: 64d01c59d68d9921d7e711674bd5f3b1fc5a0251
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f9836204ac87c171b1a17d321288358680019a5a&tochange=64d01c59d68d9921d7e711674bd5f3b1fc5a0251

I am currently filing this on the browser's side because the extension's last update date was earlier than the dates in the regression range.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1829137, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[aoia7rz7l]

Actually this does not seem to be reproducible (in both normal and private windows) if I wait for like 5 minutes into a new session before clicking on anything. Not sure why though.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks... So this looks like some sort of race with how extensions size the panel, which is using .getContentSize. It's unlikely that a patch making the returned size larger would end up causing overflow, so my guess is that something along here is not listening for a change that grows the content slightly or so...

Comment 5

[Alex Cornestean]

Hello,

I reproduced the issue on the latest Nightly (118.0a1/20230808212319), Beta (117.0b5/20230808215502) and Release (116.0.2/20230805021307) under Windows 10 x64 and Ubuntu 22.04 LTS.

The issue occurs as described in Comment 0. See the attached screenshots for more details.

Comment 6

[Alex Cornestean]

Attachment: first opening.png

Comment 7

[Alex Cornestean]

Attachment: second opening.png

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1829137

Comment 9

[aoia7rz7l]

This also seem to affect CanvasBlocker's pageAction popup. Unlike the case for the browserAction popup, you can easily get the scrollbars to reappear in the pageAction popup within the same session simply by waiting for a minute or two before re-opening it.

Comment 10

[Tomislav Jovanovic :zombie]

This seems like it would be easier to fix on the extension side, please report the issue to them.

Comment 11

[Abhishek Nagekar [:Abhi]]

Reached out to developer over AMO