1829260 - The selected menus in the menu bar weren't highlighted in Firefox 114.0a1 20230420212414

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, defect)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

I started Firefox 114.0a1 20230420212414 on Wayland in Plasma 5.27.4 in a Fedora 38 KDE Plasma installation. I had previously enabled the menu bar. The OS Theme is Breeze / Adwaita in Troubleshooting Information. I clicked on various menus in the menu bar. I moved the cursor over the menus in the menu bar.

Actual results:

The selected menus in the menu bar weren't highlighted in light blue in Firefox 114.0a1 20230420212414 as they were in previous builds. The selected menus were underlined in blue. I bisected with MOZ_ENABLE_WAYLAND=1 mozregression --good 20230420092216 --bad 20230420212414 --persist /tmp/mozregression -p ~/.mozilla/firefox/z8d4nvrc.default-nightly

The first bad revision was for Bug 1828413 - Use more non-native rendering of menus.

4:51.73 INFO: Narrowed integration regression window from [7a4c240d, 0a0b742f] (4 builds) to [7a4c240d, df18ff71] (2 builds) (~1 steps left)
4:51.73 INFO: No more integration revisions, bisection finished.
4:51.73 INFO: Last good revision: 7a4c240d12ad8c954af3935ca8e3616343647d25
4:51.73 INFO: First bad revision: df18ff71a63d4d18e7cf9d6d2a0b0f0662076264
4:51.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7a4c240d12ad8c954af3935ca8e3616343647d25&tochange=df18ff71a63d4d18e7cf9d6d2a0b0f0662076264

I'm not sure if this might've been an intentional change. The menus weren't highlighted with 114.0a1 20230420212414 on XWayland.

Expected results:

The selected menus in the menu bar should have been highlighted in light blue as they were previously.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1828413, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This is intentional. The underline is what adwaita does so I matched that. The previous background change overlaps with the csd corner, and the underline also fixes that.