1828413 - Menus look odd with some GTK themes.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: image.png

Bug 1827026 mentions some themes where menus look a bit odd, see screenshot.

I have an idea to improve the looks of our menus a bit more generally, see incoming patch.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1828413 - Use more non-native rendering of menus. r=stransky

This makes our menus closer to GTK4, and depends less on the native menu
rendering etc. Thunderbird already does this to some extent.

Leave the old code behind a pref for now (just in case). Also fix some
code in nsNativeTheme::GetContentState (fixes rendering of radio menu
items).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c099d64b17e6
Use more non-native rendering of menus. r=stransky

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset c099d64b17e6 (Bug 1828413) for causing multiple Menu related failures

Backout: https://hg.mozilla.org/integration/autoland/rev/8a9a836e2fe60baaa7aed7b34b71a468db21aca9

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=c099d64b17e6c2bed021b431528baeef0c2ba6bc

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=412987564&repo=autoland&lineNumber=6054
https://treeherder.mozilla.org/logviewer?job_id=412990916&repo=autoland&lineNumber=3105
https://treeherder.mozilla.org/logviewer?job_id=412990937&repo=autoland&lineNumber=3738
https://treeherder.mozilla.org/logviewer?job_id=412988317&repo=autoland&lineNumber=29034
https://treeherder.mozilla.org/logviewer?job_id=412991239&repo=autoland&lineNumber=124471
https://treeherder.mozilla.org/logviewer?job_id=412991259&repo=autoland&lineNumber=12131

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df18ff71a63d
Use more non-native rendering of menus. r=stransky

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45ebaeec775f
Fix a11y tests so that they don't hover over the rounded corner.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11678fb487f2
Temporarily disable a test on Linux while I investigate how to reproduce it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b00871bc37dd
Ensure menubar menus are non-fractional, and re-enable browser_mouse_enterleave_switch_tab on Linux.

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/df18ff71a63d
https://hg.mozilla.org/mozilla-central/rev/45ebaeec775f
https://hg.mozilla.org/mozilla-central/rev/11678fb487f2

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b00871bc37dd