1829305 - Crash in [@ core::result::unwrap_failed | wgpu_server_encoder_copy_texture_to_buffer]

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

7 crashes from 4+ different machines - all run Arch Linux and Firefox 114.0a1. This aligns with the landing of bug 1827421.

Crash report: https://crash-stats.mozilla.org/report/index/dfa6d251-0f6e-4a15-901d-891260230421

MOZ_CRASH Reason: called `Result::unwrap()` on an `Err` value: Transfer(UnspecifiedBytesPerRow)

Top 10 frames of crashing thread:

0  libxul.so  MOZ_Crash  mfbt/Assertions.h:261
0  libxul.so  RustMozCrash  mozglue/static/rust/wrappers.cpp:18
1  libxul.so  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:91
2  libxul.so  core::ops::function::Fn::call  library/core/src/ops/function.rs:79
3  libxul.so  <alloc::boxed::Box<F, A> as core::ops::function::Fn<Args>>::call  library/alloc/src/boxed.rs:2002
3  libxul.so  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:692
4  libxul.so  std::panicking::begin_panic_handler::{{closure}}  library/std/src/panicking.rs:579
5  libxul.so  std::sys_common::backtrace::__rust_end_short_backtrace  library/std/src/sys_common/backtrace.rs:137
6  libxul.so  rust_begin_unwind  library/std/src/panicking.rs:575
7  libxul.so  core::panicking::panic_fmt  library/core/src/panicking.rs:64

Comment 1

[Erich Gubler [:ErichDonGubler]]

An easy way to repro this on all platforms currently is to navigate to https://webgpu.github.io/webgpu-samples/samples/cubemap. I'll be taking investigation on this.

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1829305: refactor(wgpu_bindings): move `ImageDataLayout` to crate root r=#webgpu-reviewers

Comment 3

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1829305: fix(webgpu): trade incorrect `ImageCopyBuffer` usage for exploded ID and FFI-friendly `ImageDataLayout` in `wgpu_server_encoder_copy_texture_to_buffer` r=#webgpu-reviewers

Depends on D176206

Comment 4

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1829305: build(webgpu): track `wgpu-hal` for `wgpu_bindings` source deps r=#webgpu-reviewers

Depends on D176207

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

:ErichDonGubler, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0fc0206bf0
refactor(wgpu_bindings): move `ImageDataLayout` to crate root r=webgpu-reviewers,jimb
https://hg.mozilla.org/integration/autoland/rev/40f7492787a9
fix(webgpu): trade incorrect `ImageCopyBuffer` usage for exploded ID and FFI-friendly `ImageDataLayout` in `wgpu_server_encoder_copy_texture_to_buffer` r=webgpu-reviewers,jimb

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ee960d8d4bc
build(webgpu): track `wgpu-hal` for `wgpu_bindings` source deps r=webgpu-reviewers,jimb

Comment 10

[Erich Gubler [:ErichDonGubler]]

This issue should be fixed now, with recent patches landing.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2a0fc0206bf0
https://hg.mozilla.org/mozilla-central/rev/40f7492787a9
https://hg.mozilla.org/mozilla-central/rev/7ee960d8d4bc

Comment 14

[Erich Gubler [:ErichDonGubler]]

For reference: this was caused by the unfortunate collision between cbindgen#710 and :nical's patch (D175262) for bug 1827421.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.