1829371 - AC: Expose an API to allow opening in app PDF files

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, task, P1)

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: [mozilla-mobile/firefox-android] Bug 1829371 - Expose an API to allow opening in third party app PDF files (#1730)

Comment 2

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/3c446639858ee4417bebf1f627f8783a93be5fc4
[main] Bug 1829371 - Expose an API to allow opening in third party app PDF files

Comment 3

[Adina Petridean QA [:apetridean]]

Hello Arturo,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or scenarios to follow?

Thank you!

Comment 4

[Oana Horvath [:ohorvath]]

I think this is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1829372 and doesn't need validation other than that. I'll remove the qe-verify label for now, please correct me if I'm wrong.

Comment 5

[Arturo Mejia [:amejia]]

Hi Adina,
We are waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=1829367 for the feature to be completed, without it we don't have UI to test :)

Comment 6

[Arturo Mejia [:amejia]]

Comment on attachment 9330691 [details] [review]
[mozilla-mobile/firefox-android] Bug 1829371 - Expose an API to allow opening in third party app PDF files (#1730)

Beta/Release Uplift Approval Request

• User impact if declined: User will see a confirmation dialog when clicking the download button in the PDF viewer.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1829159, Bug 1829367
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are only introducing a new flag that will ignore the confirmation dialog for downloading a pdf file on the pdf viewer.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9330691 [details] [review]
[mozilla-mobile/firefox-android] Bug 1829371 - Expose an API to allow opening in third party app PDF files (#1730)

Sounds like we're in alignment to target 114 with this work.