1829394 - Page info > media, when more than one item is selected the "?" button sits on top and blocks the "Save as" button and opens the help page.

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[cosmicandy]

Attachment: Image of Firefox Page Info > Media tab > Save As button blocked by help button (?)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

Firefox 112.0.1 (64-bit) macOS version -

1. Click "Tools" menubar >
2. Page info window appears >
3. click on Media tab >
4. Select multiple items to Save >
5. Help button (?) blocks the Save As button at the bottom of the window

Actual results:

The help button "?" sits on top of the of the "Save As..." button at the bottom of the window, therefore blocking it. When clicked, it ONLY opens the help page.

Expected results:

When multiple items are selected or select all, the help button (?) should be to the left or right of the "Save As..." button so Save As can be clicked.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: Screenshot 2023-04-26 at 15.06.19.png

I couldn't manage to reproduce the issue on my end, both buttons are displayed separately. (see screenshot attached)
Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

Comment 2

[cosmicandy]

Attachment: Firefox Save As and ? button top pane resized Screenshot 2023-04-26.png

Comment 3

[cosmicandy]

(In reply to Hani Yacoub, Desktop QA from comment #1)

Created attachment 9330365 [details]
Screenshot 2023-04-26 at 15.06.19.png

I couldn't manage to reproduce the issue on my end, both buttons are displayed separately. (see screenshot attached)
Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

I just updated to the regular build version 112.0.2 (64-bit) and it's still having the same issue.
So played around with resizing the window and resizing the inner panes and discovered when it the overlay of the ? button and save as button occurs:
When you first open the Page Info Window and start selecting the upper pane it displays the Save As button above the ? as you have it in your screenshot.
However, once you resize the upper pane (to see more items) and start selecting multiple items, that’s when the ? button overlaps the Save As button.

Comment 4

[jasonmowry]

I can confirm all the same behavior as reported by the original issue reporter. This is reproducible as described in the latest release of Firefox for MacOS, so please update the issue status and address this bug in your next build cycle.

Comment 5

[jasonmowry]

Attachment: Screenshot of Firefox Page Info window with incorrect layout making Save As button inaccessible

Attaching a screenshot which illustrates the reproduction of this issue.

Comment 6

[Florian Quèze [:florian]]

I can reproduce, using the additional information in comment 3: the two panes need to be resized before selecting multiple images.

mozregression says https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6d37ee664b922e926a686feba165b20a628626e3&tochange=62fd688e335958ef1e95328d7bab329be8ad3a0f -> bug 1815255

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815255

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1829394 - Make media splitter only resize the tree. r=Gijs

That's the only thing we care about, otherwise we set "height: 0" on
collapsed items and when we uncollapse it (and not remove them) flex
honors it (unlike XUL where that acted as a min-height).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b023dbad83
Make media splitter only resize the tree. r=Gijs

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f7b023dbad83

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9338670 [details]
Bug 1829394 - Make media splitter only resize the tree. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9338670 [details]
Bug 1829394 - Make media splitter only resize the tree. r=Gijs

Approved for 115.0b6.

Comment 14

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6e68416dea4

Comment 15

[Ciprian Georgiu, Desktop QA]

Hi Emilio! I'm still seeing the overlapping issue when resizing the Page info panel - Media tab. The help button "?" is overlapping the "Save as..." button as can be seen in this screencast.

I'm on macOS 10.15 with latest Nightly 116.0a1 (2023-06-14). Can you please take a look at this?

Comment 16

[Daniel Bodea [:danibodea]]

Same as Hani Yacoub mentioned in comment 1, I cannot reproduce the original issue, even with the steps mentioned in comment 3.
I have tested this issue on a MacBook Air 13-inch 2013 with MacOS 11.6.8.

Furthermore, I can reproduce the secondary issue mentioned by Ciprian Georgiu in comment 15.

This being said, I cannot verify this fix using my system.

@cosmicandy & @jasonmowry & @Florian Quèze : Could you verify if this issue is fixed in later Beta builds (v115.0b6 or above) and the latest Nightly v116.0a1?

Thank you for your contribution!

Comment 17

[Emilio Cobos Álvarez (:emilio)]

I could repro on yesterday's nightly but not on the latest one...

Comment 18

[Emilio Cobos Álvarez (:emilio)]

(In reply to Ciprian Georgiu, Desktop QA from comment #15)

Hi Emilio! I'm still seeing the overlapping issue when resizing the Page info panel - Media tab. The help button "?" is overlapping the "Save as..." button as can be seen in this screencast.

Ah, I had not seen the screencast, sorry! That seems like a separate issue. This was about the splitter resizing, per comment 6. I'd file a separate bug for that.

Comment 19

[Ciprian Georgiu, Desktop QA]

Thanks, Emillio!(In reply to Emilio Cobos Álvarez (:emilio) from comment #18)

Ah, I had not seen the screencast, sorry! That seems like a separate issue. This was about the splitter resizing, per comment 6. I'd file a separate bug for that.

Thank you! I've filed Bug 1839133.

I've chatted a bit offline with Emillio about the initial issue, and I was able to reproduce it as well, after trying the additional steps mentioned in comment 3. I had to resize a bit the page info panel's height (the one containing the addresses) then select multiple links.

I'm going to mark this as verified fixed since the above steps are not reproducing anymore on latest Nightly 116.0a1 and Beta 115.0b7 with macOS 11.