1829426 - Land device migration "welcome back" onboarding screen

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

These screens should be used for onboarding when the user has gone through the device migration attribution funnel. See https://www.figma.com/file/qe9yX8x51jjbt6DJYgayg2/Device-Migration?node-id=2316-18398&t=v5vYh6HWYizKQxtN-4 for an example set of screens for default device migration onboarding.

We need to make sure that we can deploy different screens to override this set were we to determine that there is a better screen ordering after uplift.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP: Bug 1829426 - Fork existing default about:welcome screens for a device migration variant. r?aminomancer!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey aminomancer, Mardak, is the patch in here an accurate reflection of the plan that was discussed in Slack?

Comment 3

[Shane Hughes [:aminomancer]]

I did make a comment in the phabricator revision, is it not showing up?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Ah weird, I never got an email about it! But yes, I see it. Thanks!

Comment 5

[Ed Lee :Mardak]

There was some discussion that the screen order not need to change where there's technical issues of related to language switcher being first. Is the screen content actually finalized or can the first screen be the multiple checkboxes "easy setup" with different copy and checkbox options?

Comment 6

[Ed Lee :Mardak]

Latest revision in figma shows a new initial "welcome back" screen for migration attribution then the rest of the screens are exactly the same as the default experience (easy with 2 checkboxes -> language -> mobile -> gratitude). https://www.figma.com/file/qe9yX8x51jjbt6DJYgayg2/Device-Migration?node-id=2316-20151&t=kPcWlK41xbDdh2Ky-0

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r?Mardak!,pdahiya!

Comment 8

[Shane Hughes [:aminomancer]]

Attachment: WIP: Bug 1829426 - Refactor AboutWelcome SMAs to return a promise. r=mconley,Mardak

Comment 9

[Shane Hughes [:aminomancer]]

Attachment: WIP: Bug 1829426 - Refactor FXA_SIGNIN_TAB_FLOW as a SMA promise. r=mconley,Mardak

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47704fa0c047
Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1830178, Bug 1829426) for causing failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Cdm0K6n_Toy1VksMMANq8g.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-linux1804-64-qr%2Fopt-mochitest-browser-chrome-spi-nw%2Cbc5&revision=917f6a2ef432c16631663da5ebc7e5a903748965

Log: https://treeherder.mozilla.org/logviewer?job_id=414081590&repo=autoland&lineNumber=10553
https://treeherder.mozilla.org/logviewer?job_id=414086010&repo=autoland&lineNumber=5161

Backout: https://hg.mozilla.org/integration/autoland/rev/80d04ac1866180a6ee9772ebf52a7e09cbbc5c4f

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd6bb0d84c4f
Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bd6bb0d84c4f

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this task using the latest Firefox Nightly 115.0a1 (Build ID: 20230508214159) downloaded from the https://www.mozilla.org/firefox/all?utm_medium=migration&utm_content=QA-1828738&utm_campaign=migration&utm_source=qa URL on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• The “Welcome Back” Device Migration screen is added to the “about:welcome” page as the first screen.
• Also, the order of the screens is respected, and all of them look as per design.