1830178 - Rename FXA_SIGNIN_TAB_FLOW to FXA_SIGNIN_FLOW and allow for opening in a new window instead of a tab

Status: RESOLVED FIXED

(Firefox :: Messaging System, task)

Description

[Mike Conley (:mconley) (:⚙️)]

There are cases when it's not possible for the user to sign-in to a Firefox Account in a new tab from an onboarding screen - for example, if the onboarding screen happens to be in a full-on window modal.

We should make it possible for the Firefox Account sign-in flow to occur within a new top-level window. If we can do this, we should also probably rename FXA_SIGNIN_TAB_FLOW to something like FXA_SIGNIN_FLOW or similar.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r?aminomancer!,Mardak!

Depends on D176453

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/917f6a2ef432
Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1830178, Bug 1829426) for causing failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Cdm0K6n_Toy1VksMMANq8g.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-linux1804-64-qr%2Fopt-mochitest-browser-chrome-spi-nw%2Cbc5&revision=917f6a2ef432c16631663da5ebc7e5a903748965

Log: https://treeherder.mozilla.org/logviewer?job_id=414081590&repo=autoland&lineNumber=10553
https://treeherder.mozilla.org/logviewer?job_id=414086010&repo=autoland&lineNumber=5161

Backout: https://hg.mozilla.org/integration/autoland/rev/80d04ac1866180a6ee9772ebf52a7e09cbbc5c4f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4772a03e52d
Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d4772a03e52d