Closed Bug 1829491 Opened 1 month ago Closed 1 month ago

Handling of the Message-ID in the header pane does not work (Clicking on M-ID / context menu: Open M-ID in Browser)

Categories

(Thunderbird :: Mail Window Front End, defect)

Thunderbird 114
defect

Tracking

(thunderbird_esr102 unaffected)

RESOLVED FIXED
114 Branch
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: infofrommozilla, Assigned: mkmelin)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(1 file)

  1. Show Message-ID or References header in the header pane (menu: View -> Headers -> All)
  2. a) Click on an Message-ID of the References header
    or
  3. b) Open context menu: "Open Browser With Message-ID"

Result Errorconsole:
2.a)

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenMessageForMessageId is not a function
    onMessageIdClick chrome://messenger/content/msgHdrView.js:3815
    connectedCallback chrome://messenger/content/header-fields.js:954
    connectedCallback chrome://messenger/content/header-fields.js:953
    buildView chrome://messenger/content/header-fields.js:909
    outputMessageIds chrome://messenger/content/msgHdrView.js:1372
    UpdateExpandedMessageHeaders chrome://messenger/content/msgHdrView.js:1253
    onEndHeaders chrome://messenger/content/msgHdrView.js:635
    processHeaders chrome://messenger/content/msgHdrView.js:760
    onStateChange chrome://messenger/content/msgHdrView.js:533

2.b)

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenBrowserWithMessageId is not a function
    openBrowser chrome://messenger/content/msgHdrView.js:3832
    oncommand about:message:1

Only fails with nntp?

Flags: needinfo?(infofrommozilla)

Correct, the bug also occurs with email.

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenMessageForMessageId is not a function
    onMessageIdClick chrome://messenger/content/msgHdrView.js:3815
    connectedCallback chrome://messenger/content/header-fields.js:954
Flags: needinfo?(infofrommozilla)
Component: Networking: NNTP → Mail Window Front End
Product: MailNews Core → Thunderbird

regression range will probably help. https://mozilla.github.io/mozregression/

It would be from the new 3pane

Assignee: nobody → mkmelin+mozilla
Whiteboard: [Supernova]
Blocks: tb-new-3pane
Whiteboard: [Supernova] → [Supernova3p]

The open message id functionality was not working. The 102 behavior of using open message pref for how to open that message didn't seem to sane, so the behavior I implemented is slightly different - always open the message in the context it was opened (3pane, tab, or window).

Easiest way to test is to set mailnews.headers.showReferences true and move some messages from a conversation to another folder. Then go to the other folder and use the References context menu in the message header.

(In reply to Magnus Melin [:mkmelin] from comment #5)

Created attachment 9329948 [details]
Bug 1829491 - Fix Handling of the Message-ID in the header pane (Clicking on M-ID / context menu: Open M-ID in Browser). r=darktrojan

Works fine for me. E-Mail and NNTP.
Thanks a lot!

Status: NEW → ASSIGNED
Target Milestone: --- → 114 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d0300a237b15
Fix Handling of the Message-ID in the header pane (Clicking on M-ID / context menu: Open M-ID in Browser). r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Regressions: 1830819
Regressions: 1831208
Regressions: 1832383
You need to log in before you can comment on or make changes to this bug.