1829491 - Handling of the Message-ID in the header pane does not work (Clicking on M-ID / context menu: Open M-ID in Browser)

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alfred Peters [:infofrommozilla]]

1. Show Message-ID or References header in the header pane (menu: View -> Headers -> All)
2. a) Click on an Message-ID of the References header
   or
3. b) Open context menu: "Open Browser With Message-ID"

Result Errorconsole:
2.a)

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenMessageForMessageId is not a function
    onMessageIdClick chrome://messenger/content/msgHdrView.js:3815
    connectedCallback chrome://messenger/content/header-fields.js:954
    connectedCallback chrome://messenger/content/header-fields.js:953
    buildView chrome://messenger/content/header-fields.js:909
    outputMessageIds chrome://messenger/content/msgHdrView.js:1372
    UpdateExpandedMessageHeaders chrome://messenger/content/msgHdrView.js:1253
    onEndHeaders chrome://messenger/content/msgHdrView.js:635
    processHeaders chrome://messenger/content/msgHdrView.js:760
    onStateChange chrome://messenger/content/msgHdrView.js:533

2.b)

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenBrowserWithMessageId is not a function
    openBrowser chrome://messenger/content/msgHdrView.js:3832
    oncommand about:message:1

Comment 1

[Wayne Mery (:wsmwk)]

Only fails with nntp?

Comment 2

[Alfred Peters [:infofrommozilla]]

Correct, the bug also occurs with email.

Uncaught TypeError: window.browsingContext.topChromeWindow.OpenMessageForMessageId is not a function
    onMessageIdClick chrome://messenger/content/msgHdrView.js:3815
    connectedCallback chrome://messenger/content/header-fields.js:954

Comment 3

[Wayne Mery (:wsmwk)]

regression range will probably help. https://mozilla.github.io/mozregression/

Comment 4

[Magnus Melin [:mkmelin]]

It would be from the new 3pane

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1829491 - Fix Handling of the Message-ID in the header pane (Clicking on M-ID / context menu: Open M-ID in Browser). r=darktrojan

The open message id functionality was not working. The 102 behavior of using open message pref for how to open that message didn't seem to sane, so the behavior I implemented is slightly different - always open the message in the context it was opened (3pane, tab, or window).

Easiest way to test is to set mailnews.headers.showReferences true and move some messages from a conversation to another folder. Then go to the other folder and use the References context menu in the message header.

Comment 6

[Alfred Peters [:infofrommozilla]]

(In reply to Magnus Melin [:mkmelin] from comment #5)

Created attachment 9329948 [details]
Bug 1829491 - Fix Handling of the Message-ID in the header pane (Clicking on M-ID / context menu: Open M-ID in Browser). r=darktrojan

Works fine for me. E-Mail and NNTP.
Thanks a lot!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0300a237b15
Fix Handling of the Message-ID in the header pane (Clicking on M-ID / context menu: Open M-ID in Browser). r=darktrojan