1829667 - Make JsepTransceiver non-refcounted, and stop sharing references to them

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task)

Description

[Byron Campen [:bwc]]

Access to the JsepTransceivers in JsepSession ought to be tightened up, especially now that they have proper identifiers (see bug 1769802). Most access ought to be by value, and failing that, using functional-style modifications so that references aren't allowed to persist beyond their intended scope.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1829667: Fix a bug in the assignment operator, and also a const-correctness fix. r?mjf

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8cf17f6d31b636853628d6f992a23308937a851f
https://treeherder.mozilla.org/jobs?repo=try&revision=1ec05d07be5911d73739acfa4d253f3e170cfc8b
https://treeherder.mozilla.org/jobs?repo=try&revision=e28d8c434f6a43eb17071b604e239782f21d55d9

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1829667: Make JsepTransceiver non-refcounted. r?mjf

Involves substantial refactoring to make most access by-value (or through
functional-style in-place modifications) for safety.

Depends on D176422

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=006779eb9a30de2d5f92b08303fd03a545d2cafb
https://treeherder.mozilla.org/jobs?repo=try&revision=e715424ba3968ff92018ce85c74d9c0fbbfb08a4
https://treeherder.mozilla.org/jobs?repo=try&revision=2e7f9a8c069e19d99ea1835fecceeeddb2cc71dc

Comment 5

[Byron Campen [:bwc]]

Wpt push is permabusted here too... maybe I need to rebase...

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b9cbcc76d2b4b0d003e5238f48ecab4a57ce4a4c
https://treeherder.mozilla.org/jobs?repo=try&revision=a1e35a291fdf705b332a9eeccf011b8ddecfbc50
https://treeherder.mozilla.org/jobs?repo=try&revision=d5f986a6f6a1847335c337b970268881a4da751f

Comment 7

[Byron Campen [:bwc]]

Rebase didn't help. This is stuck until we can get the problem with wpt try resolved.

Comment 8

[Byron Campen [:bwc]]

Filed bug 1830520. Proceeding with pathless try push, hopefully that works.

https://treeherder.mozilla.org/jobs?repo=try&revision=a24413836c9ed72bb6fe069513f9312c018e4452

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cfd10fcb68d
Fix a bug in the assignment operator, and also a const-correctness fix. r=mjf
https://hg.mozilla.org/integration/autoland/rev/6e8fbf07f4b9
Make JsepTransceiver non-refcounted. r=mjf,webidl,mccr8

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0cfd10fcb68d
https://hg.mozilla.org/mozilla-central/rev/6e8fbf07f4b9