1829707 - Video streamed in Pip is not displaying correctly

Status: REOPENED

(Firefox for Android :: Browser Engine, defect, P3)

Description

[eclaudiu64]

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:109.0) Gecko/113.0 Firefox/113.0

Steps to reproduce:

1. Enter this YouTube video: https://www.youtube.com/watch?v=NYi5CCPkIJU
2. Enter landscape mode, full screen.
3. Enter Pip mode.
4. The floating video does not display correctly on the screen.

Actual results:

The floating video does not display correctly on the screen.

Expected results:

The floating video must display correctly according to the video format. Also tested on Chrome browser and the video is streamed in Pip in the correct format.

Comment 1

[eclaudiu64]

Attachment: XRecorder_24042023_193443_001_001_001_001_001.mp4

This is from Firefox.

Comment 2

[eclaudiu64]

Attachment: XRecorder_24042023_193228.mp4

And this from Chrome, where it can be seen that it is being displayed at the full ql format of the video.

Comment 3

[Chris Peterson [:cpeterson]]

Thanks for the bug report. I think this is a duplicate of bug 1827583. We've reached out to YouTube for more information.

Comment 4

[Chris Peterson [:cpeterson]]

Reopening this bug because eclaudiu64 says it's not a duplicate of bug 1827583.

Comment 5

[eclaudiu64]

(In reply to Chris Peterson [:cpeterson] from comment #4)

Reopening this bug because eclaudiu64 says it's not a duplicate of bug 1827583.

Somehow this issue is also related to this ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1813890

Comment 6

[Makoto Kato [:m_kato]]

Should we set PiP params (PictureInPictureParams) for source rect hint / aspect ratio?

https://searchfox.org/mozilla-mobile/rev/d83ccc2046713f266c99f274d0749c695b91e347/firefox-android/android-components/components/feature/session/src/main/java/mozilla/components/feature/session/PictureInPictureFeature.kt#72

Comment 8

[Makoto Kato [:m_kato]]

setSourceRectHint seems to be able to change default PiP window size, but PiP API doesn't set clipping bounds. So if you use setSourceRectHint, it causes another issue that top part isn't rendered in PiP window. setSourceRectHint uses Rect, but it seems to be used for width and height.

Comment 9

[Makoto Kato [:m_kato]]

On youtube.com, fullscreen element is video player, not video element. Then after fullscreen, when resizing window to fit video size, video element becomes that top position is changed to out of screen. I guess that youtube.com doesn't consider this situation. So we need to hack youtube.com's content script to fix this.

Reporter, do you have any example on non Youtube.com site?

Comment 10

[eclaudiu64]

(In reply to Makoto Kato [:m_kato] from comment #9)

On youtube.com, fullscreen element is video player, not video element. Then after fullscreen, when resizing window to fit video size, video element becomes that top position is changed to out of screen. I guess that youtube.com doesn't consider this situation. So we need to hack youtube.com's content script to fix this.

Reporter, do you have any example on non Youtube.com site?

Now I noticed that I put the YouTube desktop link in the original post, actually this problem is on the mobile version of YouTube, on this link: https://m.youtube.com/watch?v=NYi5CCPkIJU

Comment 11

[eclaudiu64]

(In reply to eclaudiu64 from comment #10)

(In reply to Makoto Kato [:m_kato] from comment #9)

On youtube.com, fullscreen element is video player, not video element. Then after fullscreen, when resizing window to fit video size, video element becomes that top position is changed to out of screen. I guess that youtube.com doesn't consider this situation. So we need to hack youtube.com's content script to fix this.

Reporter, do you have any example on non Youtube.com site?

Now I noticed that I put the YouTube desktop link in the original post, actually this problem is on the mobile version of YouTube, on this link: https://m.youtube.com/watch?v=NYi5CCPkIJU

I saw that there are different situations between the mobile version and the desktop version of YouTube. I hope you can fix the problem on the mobile version and then maybe on the desktop version as well.

Comment 12

[Makoto Kato [:m_kato]]

(In reply to eclaudiu64 from comment #11)

I saw that there are different situations between the mobile version and the desktop version of YouTube. I hope you can fix the problem on the mobile version and then maybe on the desktop version as well.

This issue depends on youtube.com's player, so I am asking you "do you know/have other sample site that is not youtube.com?".

Comment 13

[eclaudiu64]

(In reply to Makoto Kato [:m_kato] from comment #12)

(In reply to eclaudiu64 from comment #11)

I saw that there are different situations between the mobile version and the desktop version of YouTube. I hope you can fix the problem on the mobile version and then maybe on the desktop version as well.

This issue depends on youtube.com's player, so I am asking you "do you know/have other sample site that is not youtube.com?".
If it depends on YouTube, why in Chrome is the video in the border visible correctly, when we put in Picture-in-Picture (PIP). Check in Chrome too and I've also put video captures from both Firefox and Chrome in this ticket.

Comment 14

[eclaudiu64]

(In reply to Makoto Kato [:m_kato] from comment #12)

(In reply to eclaudiu64 from comment #11)

I saw that there are different situations between the mobile version and the desktop version of YouTube. I hope you can fix the problem on the mobile version and then maybe on the desktop version as well.

This issue depends on youtube.com's player, so I am asking you "do you know/have other sample site that is not youtube.com?".

If it depends on YouTube, why in Chrome is the video in the border visible correctly, when we put in Picture-in-Picture (PIP). Check in Chrome too and I've also put video captures from both Firefox and Chrome in this ticket.

Comment 15

[Makoto Kato [:m_kato]]

If it depends on YouTube, why in Chrome is the video in the border visible correctly, when we put in Picture-in-Picture (PIP). Check in Chrome too and I've also put video captures from both Firefox and Chrome in this ticket.

Generally, web content runs other content scripts per browser. So if we fit window size with video size, youtube's content script seems to set video element position (top positon) is out of screen (When using devtools, video element becomes negative position). Actually although we don't set aspect ratio for PiP, if set it, this occurs another issue (top position is negative then top is not visible).

So I want to know if this issue occurs on non youtube.com site.

Comment 16

[eclaudiu64]

(In reply to Makoto Kato [:m_kato] from comment #15)

If it depends on YouTube, why in Chrome is the video in the border visible correctly, when we put in Picture-in-Picture (PIP). Check in Chrome too and I've also put video captures from both Firefox and Chrome in this ticket.

Generally, web content runs other content scripts per browser. So if we fit window size with video size, youtube's content script seems to set video element position (top positon) is out of screen (When using devtools, video element becomes negative position). Actually although we don't set aspect ratio for PiP, if set it, this occurs another issue (top position is negative then top is not visible).

So I want to know if this issue occurs on non youtube.com site.

I haven't noticed this on other sites, only on youtube and other sites that contain all links created to YouTube, like this one: https://video.link/w/Zoy6-zFuY-E#

Comment 17

[eclaudiu64]

Can this error be worked on?