Closed Bug 1829712 Opened 2 years ago Closed 2 years ago

Remove DOM element from WeakMap after listeners are removed

Categories

(Firefox :: Search, task, P2)

task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: jteow, Assigned: jteow)

References

Details

Attachments

(1 file)

Without this step, it's possible for the WeakMap to still contain the object on a subsequent page loads on the same SERP domain and iterating over the elements will cause TypeError: can't access dead object errors.

This is reproducible by running --verify on search telemetry tests and searching for that error.

Assignee: nobody → jteow
Status: NEW → ASSIGNED
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c1c2b679b53 Remove DOM element from WeakMap after listeners are removed - r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: