1830056 - Nimbus integration with Search Service can to set up experiments before the search service has initialised

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Mark Banner (:standard8)]

I had a test experiment applied which was setting extra parameters on engines. When restarting with the experiment enabled I noticed the error below on the console.

This doesn't break initialisation, but looks like it could break the experimentation set-up around the default private engine work.

Error: Something tried to use the search service before it's been properly intialized. Please examine the stack trace to figure out what and where to fix it:
#ensureInitialized@resource://gre/modules/SearchService.sys.mjs:1255:15
get defaultPrivateEngine@resource://gre/modules/SearchService.sys.mjs:189:28
#checkNimbusPrefs@resource://gre/modules/SearchService.sys.mjs:3225:34
#nimbusSearchUpdated@resource://gre/modules/SearchService.sys.mjs:3198:27
_onFeatureUpdate@resource://nimbus/lib/ExperimentStore.sys.mjs:390:17
onUpdate@resource://nimbus/ExperimentAPI.sys.mjs:472:26
#addObservers@resource://gre/modules/SearchService.sys.mjs:3274:32
#init@resource://gre/modules/SearchService.sys.mjs:1332:25
async*init@resource://gre/modules/SearchService.sys.mjs:366:23
getDefault@resource://gre/modules/SearchService.sys.mjs:205:16
_updateURLBarPlaceholderFromDefaultEngine@chrome://browser/content/browser.js:3836:31
delayedStartupInit@chrome://browser/content/browser.js:3696:10
_delayedStartup@chrome://browser/content/browser.js:1871:19
EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1773:12
EventHandlerNonNull*@chrome://browser/content/browser.xhtml:116:39

Comment 1

[Mihai Popa [:papermario]]

Could you create and attach a patch?

Comment 2

[Mark Banner (:standard8)]

I think here, we should wait for this.init() in nimbusSearchUpdated.

We should also avoid the extra _maybeReloadEngines - by only doing that if we are making an actual change in checkNimbusPrefs.

Comment 3

[Mark Banner (:standard8)]

Bug 1883685 has reworked this so that we're no longer using isEarlyStartup and the main part of the search service no longer listens directly to Nimbus, hence this should no longer be a potential issue.