1883685 - Migrate searchConfiguration to use setPref instead of isEarlyStartup

Status: VERIFIED FIXED

(Firefox :: Search, task, P3)

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1883685 - Migrate Nimbus searchConfiguration feature to use setPref instead of isEarlyStartup. r?#search-reviewers!,beth!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca53ba0147ff
Migrate Nimbus searchConfiguration feature to use setPref instead of isEarlyStartup. r=beth,search-reviewers,scunnane

Comment 3

[Mark Banner (:standard8)]

Moving this across to search, as that's where we did the work.

We should also do some QA verification to ensure that the the searchConfiguration feature still works correctly for experiment, seperatePrivateDefaultUIEnabled and seperatePrivateDefaultUrlbarResultEnabled parameters.

It'll take a day or two for nightly builds to get the patches & Nimbus to update, but I can set something up once that is done & we're ready to test.

Comment 4

[agoloman]

Backed out for causing bc failures @browser_searchModeSwitcher_basic.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/521559e48007
Migrate Nimbus searchConfiguration feature to use setPref instead of isEarlyStartup. r=beth,search-reviewers,scunnane

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/521559e48007

Comment 7

[Adrian Florinescu [:aflorinescu]]

Using nimbus-preview + search-configv2 from stage-preview with 137.0a1, 136.0b6 - set with search experiment content:

• Test the experiment variable

  • Control branch, partner code (pc) becomes MOZI-NON-ADS

  • Treatment branch, pc becomes MOZI-ADS

• Test the extraParams variable

  • Control branch, additional parameter added extratag=non

  • Treatment branch, additional parameter added extratag=block

No issues found with the search experiment parameters and modified search engine. Tested also default engines, removal/restoration, telemetry, params, search codes, private mode.

The only note for eco-sys team visibility and tranparency is that for search-config RS experiment updates, the same change needs to be operated into the search-telemetry-v2 RS, otherwise withads and adclicks won’t record the expected telemetry.