1830209 - Refactor SearchSERPTelemetry ContentHandler.observeActivity

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

Couple things I could do better here:

• Improve the documentation of the logic
• Be more intentional about when we emit warnings: We should only see warnings if we have an event from a SERP, but didn't record the event elsewhere and don't have a type associated with it.
• Move !info.nonAdsLinkRegexps.some(r => r.test(originURL)) check later in the process: We always need to check if the URL matches a SERP so that we can record the source of a possible impression. In some scenarios, we won't know this information until after a redirect.
• I structured things the way they were before to separate the algorithmic complexity of finding the type from recording the Glean event for perf measurements, but it made reading the code slightly harder to understand.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1830209 - Refactor observeActivity - r?standard8,scunnane

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/438845dd89a7
Refactor observeActivity - r=Standard8

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/438845dd89a7