1830306 - `Mark thread as read` is disabled except for a single selected message in a thread - should always be enabled as in 102 when selection contains one message in a thread, for multiple selected threads etc.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: `Mark thread as read` should be enabled and do as told on this selection

Mark thread as read is disabled except for a single selected message in a thread - should always be enabled as in 102 when selection contains one message in a thread, for multiple selected threads etc. To rephrase, here's the expected behaviour in Wayne's words, from 17-year-old bug 327828 comment 1:

"Mark thread as read" marks every thread read in which you have at least one message selected, as one would expect.

This will have a significant impact on ux-efficiency for users with large amounts of mail in threads (think bugmail...)

STR

1. View > Layout > Classic View (tabular message list)
2. For starters, ensure mail.operate_on_msgs_in_collapsed_threads = true (default). Wayne says it should be the same regardless of the pref - sounds right, but I haven't tried. Furthermore, for the scenario below it doesn't matter if your message list is threaded or not.
3. Play with different type of selections, or all at once (see screenshot):
   Select...
   a) single msg which belongs to thread
   b) all messages of an open thread (or closed thread)
   c) combine a) and b)
   d) add to the selection a message which does not belong to a thread.
4. Right-click on selection, check enabled status of Mark > Thread as read

Actual

• Mark Thread as read is only enabled for case a), single msg which is part of thread
• Mark Thread as read is disabled for every other type of selection (this bug)
• (Of course shortcut R will also fail as the command is disabled)
• This means that even everyday scenarios like marking multiple adjacent collapsed threads as read will fail.

Expected

• Mark Thread as read should be enabled whenever the selection contains at least one message which is part of a thread.
• Mark Thread as read should then do the job as per its label, mark all threads associated with the selection as read (even when they are only partly selected).
• For added convenience, as in 102, case d) of the odd non-thread message in a selection which has at least one thread message shouldn't disable the command, but just mark that message read, too.

Kudos to Wayne for pointing out that the command is no longer working as expected.

Comment 1

[Magnus Melin [:mkmelin]]

The logic is the same in the 102 code, but there must have been another bug (with the counts) that prevented it to work the intended: if the selection has any unread, it should be enabled.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1830306 - `Mark thread as read` should be enabled when selection contains one unread message, for multiple selected threads etc. r=#thunderbird-reviewers

Comment 3

[Christian Riechers]

Not sure if it's the same problem, but possibly related.
When a thread with all messages unread is collapsed, and then being selected in the thread pane, it cannot be marked as read by hitting the R key.
This did work in v102.

Comment 4

[Magnus Melin [:mkmelin]]

That should be the same as the hotkey is connected to the command, and the command enabling/disabling was not working as it should.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/26c175c82167
Mark thread as read should be enabled when selection contains one unread message, for multiple selected threads etc. r=aleca

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1830306 - Follow-up - adjust browser_messageMenu.js. r=#thunderbird-reviewers

markThreadAsRead is enabled since one of the messages are read.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7a64939f68a0
Follow-up - adjust browser_messageMenu.js. r=john.bieling