1830588 - Graphical error on animated box

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[u693231]

Steps to reproduce:

hello,
we are receiving reports from users that there is a graphical problem in the clipboard2file extension in firefox nightly that is not present in other versions.

to see the issue for yourself, please go to https://addons.mozilla.org/en-US/firefox/addon/clipboard2file/ and install the extension (following all instructions on the page), then copy an image to the clipboard and try to upload it to a website like imgur, google drive, etc

Actual results:

there is a line on the side of the box

Expected results:

the line should not present as it is not intended

Comment 1

[u693231]

Attachment: bug.mp4

Comment 2

[Darkspirit]

Thanks for the report! Confirmed on KDE Wayland, Debian Testing, Intel.
It's like an additional 1px border at the right & bottom for a part of a second.

Install addon, go to Google Images tab, copy google logo, click to upload file, press escape, click to upload file, etc.
mozregression --good 2023-02-01 --bad 2023-04-29 --pref dom.events.asyncClipboard.clipboardItem:true -a https://addons.mozilla.org/en-US/firefox/addon/clipboard2file/ -a https://www.google.com/imghp

16:33.35 INFO: Last good revision: dccf044ce33a90816e6a0da2fec9a5d7d05b5924
16:33.35 INFO: First bad revision: 1c58e8743220c7cab1ee952fa3d3a5ba046575cc
16:33.35 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dccf044ce33a90816e6a0da2fec9a5d7d05b5924&tochange=1c58e8743220c7cab1ee952fa3d3a5ba046575cc

1c58e8743220c7cab1ee952fa3d3a5ba046575cc Glenn Watson — Bug 1823578 - Add new clip-mask rendering path r=gfx-reviewers,ahale

Comment 3

[Glenn Watson [:gw]]

This should be temporarily resolved when bug #1830691 lands. I'll work on a proper fix for this before re-enabling the new clip-mask path.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823578

Comment 5

[Glenn Watson [:gw]]

I can see the bug in the referenced video. However, when I re-enable the new clip-mask path I can't observe the bug locally.

I'm not sure if it's been resolved by some other change, or if the bug only reproduces under certain scenarios, or if I'm just not looking closely enough.

I pushed a try build to https://treeherder.mozilla.org/jobs?repo=try&revision=66296cc9b88936a39700f6fd3382be54b6a8c82a with the new path enabled. Would it be possible for you to locally test the artifacts from that, when they're built, and see if you can still observe the bug?

Comment 6

[u693231]

hello,
yes we can observe the bug locally (downloaded file named target.tar.bz2)

Comment 7

[Glenn Watson [:gw]]

Thanks for confirming, I can also reproduce it locally now.

Comment 8

[Glenn Watson [:gw]]

Attachment: Bug 1830588 - Fix clip on fractional composite prims

Also add a test and re-enable the new clip-mask code paths.

Comment 9

[Glenn Watson [:gw]]

The attached patch fixes this problem for me locally. If you'd like to verify yourself, there is a try run with the patch applied available at [1]. Otherwise, it should be in nightly within the next 2-3 days.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=1583625dd888b86c2886d9571cd766721ce250da

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/928b0d1a27d5
Fix clip on fractional composite prims r=gfx-reviewers,lsalzman

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/928b0d1a27d5

Comment 12

[Glenn Watson [:gw]]

I discussed on matrix with Donal that the least risky option for this release will likely be to back out 1836693, 1836052 and then 1830588 (this bug) from beta. I've checked that these revert cleanly on beta, and submitted a try run:

https://treeherder.mozilla.org/jobs?repo=try&revision=b8b3e56c4f51bef9610b3fa7ea950982cbe5e54b

I'll update this comment with the results of that try run, but I expect it should be a safe change.

Comment 13

[Glenn Watson [:gw]]

Donal, confirming that the try run above looks good to me - so it should be fine to apply those 3 back outs to beta, thanks.

Comment 14

[Monica Chiorean]

I tried reproducing on Ubuntu 20.04 and Win10 using FF build 114.0a1(20230428092401), but it did not reproduce.
Can you please confirm the fix on latest Beta 115.0b9(link https://archive.mozilla.org/pub/firefox/candidates/115.0b9-candidates/build1/win64/en-US/). Thank you.

Comment 15

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/fa7043f1c4a2
Backed out changeset 928b0d1a27d5 (bug 1830588) with Bug 1836052 and Bug 1836693 for causing regressions

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr115/rev/24630fd6a7af
Backed out changeset 928b0d1a27d5 (bug 1830588) with Bug 1836052 and Bug 1836693 for causing regressions