Closed Bug 1839309 Opened 1 year ago Closed 1 year ago

Rendering error on a codepen demo (https://codepen.io/argyleink/pen/BaLedvd)

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- fixed
firefox114 --- unaffected
firefox115 --- fixed
firefox116 --- fixed

People

(Reporter: mayankleoboy1, Assigned: gw)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(4 files)

Go to https://codepen.io/argyleink/pen/BaLedvd
Hover mouse over the boxes.
The box will split into different "sub-boxes"

ER: The text boxes with the name of the "sub-boxes" have a black background

AR:

  1. The text boxes with the name of the "sub-boxes" dont have the black background
  2. The last sub-box ("Shadox box") has the black background applied but it looks kind of distorted
  3. If you pinch-zoom on the demo pane, at certain zoom levels all the text-boxes get a distorted black background (Note that this particular behaviour only occurs on the codepen/live version of the demo)

Regression Range:
Bug 1830588 - Fix clip on fractional composite prims r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D178614

Attached file about:support
Attached file index.html

Standalone_testcase.
Note that this standalone testcase repros only #1 and #2 of the buggy behaviours. To repro the #3 buggy behaviour, please use the Codepen/live version.

Flags: needinfo?(gwatson)

Set release status flags based on info from the regressing bug 1830588

Assignee: nobody → gwatson
Severity: -- → S3
Flags: needinfo?(gwatson)

:gw the final 115.0 beta build is on 2023-06-22, next week is RC week.
Do you plan on looking at this before then?

Flags: needinfo?(gwatson)

Unlikely I will get to this before then.

Flags: needinfo?(gwatson)

I will take a look at it today actually, and see if I can at least work out what the cause is.

Minimal test case:

<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <style type="text/css">

    .card {
      transform: rotateX(45deg) rotate(45deg) translateY(20vh) translateX(20vh);
      color: red;
    }

    .card::after {
        content: "Broken";
        position: absolute;
        padding: 1ch 2ch;
        border-radius: 4ch;
        transform: rotate(-45deg) rotateY(45deg) translateX(20px);
        background: black;
      }

    body {
      display: flex;
      align-items: center;
      justify-content: center;
    }
  </style>
</head>
<body>
  <div class="card"></div>
</body>
</html>

And a minimal wrench test case:

---
root:
  items:
    - type: stacking-context
      transform: rotate-x(45) rotate-z(45) translate(200, 200)
      transform-origin: 100 100
      items:
        - type: stacking-context
          transform: rotate-z(-45) rotate-y(45) translate(20, 0)
          transform-origin: 100 100
          items:
            - type: clip
              id: 3
              complex:
                - rect: [0, 0, 200, 100]
                  radius: 16
            - bounds: [0, 0, 200, 100]
              type: rect
              color: red
              clip-chain: [3]
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4326154cfca Fix new clip-paths on 2d transforms that affect z-coords without preserve-3d r=gfx-reviewers,lsalzman
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(gwatson)

This is fixed in the latest Nightly. Thanks!

Comment on attachment 9340420 [details]
Bug 1839309 - Fix new clip-paths on 2d transforms that affect z-coords without preserve-3d

Beta/Release Uplift Approval Request

  • User impact if declined: Visible rendering bugs on some pages
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch, clear fix, has been in nightly.
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(gwatson)
Attachment #9340420 - Flags: approval-mozilla-beta?

:gw there are several conflicts when grafting this patch to beta, introduced by Bug 1837103 which is only in central.
Could you attach a patch rebased on beta?

Flags: needinfo?(gwatson)

Donal, would you be OK with taking that patch (1837103) as well - they're all interrelated, so I think it will be safer to take both patches rather than try to rebase this directly on beta.

Flags: needinfo?(gwatson) → needinfo?(dmeehan)

Comment on attachment 9340420 [details]
Bug 1839309 - Fix new clip-paths on 2d transforms that affect z-coords without preserve-3d

Rejecting uplift request, the regressor will be backed out of release for Fx115

Flags: needinfo?(dmeehan)
Attachment #9340420 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Setting Fx115 to Fixed, the regressor Bug 1830588 was backed out of Fx115 release.

Setting esr115 to Fixed, the regressor Bug 1830588 was backed out of esr115 for 115.0esr

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: