Closed Bug 1830645 Opened 1 years ago Closed 1 years ago

Alt text like [NoIcon Annotation] displays because src points to host web site

Categories

(Firefox :: PDF Viewer, defect)

Firefox 112
defect

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- wontfix
firefox113 --- fixed

People

(Reporter: jscher2000, Assigned: Snuffleupagus)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The viewer renders a textAnnotation with a canvas and an image. In the example, the image has:

src="./images/annotation-noicon.svg" alt="[NoIcon Annotation]"

The alt text displays because the image path ends up calculated relative to the website rather than to the viewer images folder.

Oddly, images on the toolbar are fine.

Reported for a different annotation image on https://connect.mozilla.org/t5/discussions/annotations-embedded-in-pdfs-are-no-longer-displayed/td-p/30604

WFM, using Firefox Nightly 114.0a1.

This should be fixed in Firefox 113, which according to https://whattrainisitnow.com/ will ship soon.


This regressed in https://github.com/mozilla/pdf.js/pull/16153 and was fixed in https://github.com/mozilla/pdf.js/pull/16228, however the reason that this bug affects Firefox 112 is because only the first of those PRs were uplifted.

(In reply to Jonas Jenwald [:Snuffleupagus] from comment #1)

This regressed in https://github.com/mozilla/pdf.js/pull/16153 and was fixed in https://github.com/mozilla/pdf.js/pull/16228, however the reason that this bug affects Firefox 112 is because only the first of those PRs were uplifted.

We should try to file bugs on Bugzilla when identifying follow-up problems such as https://github.com/mozilla/pdf.js/pull/16228, so we can more easily track things and uplift all that needs to be uplifted.

Status: NEW → RESOLVED
Closed: 1 years ago
Depends on: 1826379
Keywords: regression
Regressed by: 1821408, 1823360
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Assignee: nobody → jonas.jenwald
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: