1830681 - Fullscreen mode has padding, doesn't occupy the whole screen

Status: RESOLVED DUPLICATE of bug 1830721

(Core :: Widget: Win32, defect)

Description

[Tomasz Sobczyk]

Attachment: bug.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Press F11 (go into fullscreen mode). Also tested on nightly.

Actual results:

The non-fullscreen windows bleeds on the edges (~10 pixels) on the bottom, left, right. Fullscreen mode doesn't occupy the whole screen.

Expected results:

Fullscreen should be fullscreen.

Comment 1

[Tomasz Sobczyk]

This was not an issue a few days ago, sadly I was away so I can't pinpoint it in time exactly.

Comment 2

[Tomasz Sobczyk]

Attachment: mozregression log

ran mozregression and found the issue commit

Comment 3

[Tomasz Sobczyk]

ran mozregression and found the issue commit, atached logs, pasting the end of logs here

2023-05-01T11:40:23.890000: DEBUG : Found commit message:
Bug 1823284 - Use `SizeModeChanged` notification to handle fullscreen change; r=geckoview-reviewers,rkraesig,stransky,bradwerth,smaug,m_kato

Depends on D175213

Differential Revision: https://phabricator.services.mozilla.com/D175215

2023-05-01T11:40:23.890000: DEBUG : Did not find a branch, checking all integration branches
2023-05-01T11:40:23.892000: INFO : The bisection is done.
2023-05-01T11:40:23.894000: INFO : Stopped

Comment 4

[Tomasz Sobczyk]

there might have been some back and forth on this behavior, since if I understand correctly the commit was only added in 114, but one commit back there's no issue, and I experience the issue on 113 too

Comment 5

[lordpatamon]

I'm experiencing this too. I think it started on v113.0b7 or so.

The current beta is v113.0b9 so 113.0b7 may be where this bug happened, or at most on v113.0b6 but not beyond that version.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 7

[Edgar Chen [:edgar]]

I cannot reproduce this issue on Windows 10 (21H2). Which Windows version are you using?

Comment 8

[lordpatamon]

(In reply to Edgar Chen [:edgar] from comment #7)

I cannot reproduce this issue on Windows 10 (21H2). Which Windows version are you using?

It is on Windows 7 and seeing the Windows NT version that the person who made this bug report is using it is Windows 7 as well since Windows NT 6.1 is the internal version for Windows 7.

Comment 9

[Edgar Chen [:edgar]]

Thanks for confirming this. It seems like the widget window somehow doesn't resize to fit the screen size.
Is it possible that you can help to get some log from Nightly by following below steps?

• Open about:logging.
• Set Logging output to "Logging to the Firefox Profiler"
• Set new log modules to Widget:5,BaseWidget:5
• Click "Set Log Modules"
• Click "Start Logging"
• (Reproduce the issue)
• Click "Stop Logging" (this will open profiler in a new tab)
• In the new tab, click "Upload Local Profile" (in top-right of the page) and "Upload" to upload profile, and then share the link to me.

If you don't want to share the profile publicly, you can email the link to me ([e-mail]). Thanks!

Comment 10

[lordpatamon]

(In reply to Edgar Chen [:edgar] from comment #9)

Thanks for confirming this. It seems like the widget window somehow doesn't resize to fit the screen size.
Is it possible that you can help to get some log from Nightly by following below steps?

• Open about:logging.
• Set Logging output to "Logging to the Firefox Profiler"
• Set new log modules to Widget:5,BaseWidget:5
• Click "Set Log Modules"
• Click "Start Logging"
• (Reproduce the issue)
• Click "Stop Logging" (this will open profiler in a new tab)
• In the new tab, click "Upload Local Profile" (in top-right of the page) and "Upload" to upload profile, and then share the link to me.

If you don't want to share the profile publicly, you can email the link to me ([e-mail]). Thanks!

Here you go:

https://share.firefox.dev/44iYxKD

Comment 11

[Edgar Chen [:edgar]]

(In reply to lordpatamon from comment #10)

Here you go:

https://share.firefox.dev/44iYxKD

lordpatamon, thanks for your log!
I suspect this issue probably occurs only when glass margins are involved, but I am not super sure.
Could you also help to capture log for normal case, so that I can compare them?
Thanks!

Comment 12

[lordpatamon]

(In reply to Edgar Chen [:edgar] from comment #11)

(In reply to lordpatamon from comment #10)

Here you go:

https://share.firefox.dev/44iYxKD

lordpatamon, thanks for your log!
I suspect this issue probably occurs only when glass margins are involved, but I am not super sure.
Could you also help to capture log for normal case, so that I can compare them?
Thanks!

Log for normal case? how do I do that? You mean get a version in which the full scree used to work fine?

Comment 13

[Edgar Chen [:edgar]]

(In reply to lordpatamon from comment #12)

You mean get a version in which the full scree used to work fine?

Yes, you could just use release channel (which fullscreen should work fine) to get log.
(Sorry, I don't have Windows 7 environment, so I need your help to get more informantion to investigate. :))
Thanks!

Comment 14

[lordpatamon]

(In reply to Edgar Chen [:edgar] from comment #13)

(In reply to lordpatamon from comment #12)

You mean get a version in which the full scree used to work fine?

Yes, you could just use release channel (which fullscreen should work fine) to get log.
(Sorry, I don't have Windows 7 environment, so I need your help to get more informantion to investigate. :))
Thanks!

Here you go:

https://share.firefox.dev/3AL2GcC

Lucky for me I have a Windows 7 dual boot (I have both Windows 7 32 bits and 64bits due to many programs installed on the 32 bits one and didn't want to reinstall anything so I use the 64 bits one for 64 bits only stuff) and on the 64 bits one I still had Firefox v112.0b9 installed in which full screen works without issues.

Comment 15

[Edgar Chen [:edgar]]

I found another bug report that seems like a similar issue, bug 1830721.
And in that bug report, the fullscreen padding disappears after minimizing and un-minimizing the fullscreen window.

Does minimizing and un-minimizing the fullscreen window also make the buggy padding disappear in your case?

Comment 16

[lordpatamon]

(In reply to Edgar Chen [:edgar] from comment #15)

I found another bug report that seems like a similar issue, bug 1830721.
And in that bug report, the fullscreen padding disappears after minimizing and un-minimizing the fullscreen window.

Does minimizing and un-minimizing the fullscreen window also make the buggy padding disappear in your case?

Sorry for the late reply.

Indeed minizing and un-minimizing the fullscreen make the buggy padding disappear, but as soon as you exit the full screen mode and activate it again the buggy padding returns.

So minimizing and un-minimizing would be just a temporary workaround.

Comment 17

[Edgar Chen [:edgar]]

Attachment: Bug 1830681 - Update non-client margins before changing fullscreen mode; r?rkraesig

We were replying on the resize event fired for fullscreen mode change to
trigger reflow. But in
https://phabricator.services.mozilla.com/D175215,
we started notifying sizemodechange after fullscreen mode has changed,
which could result in the layout not being updated properly.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823284

Comment 19

[Phabricator Automation]

Comment on attachment 9331489 [details]
Bug 1830681 - Update non-client margins before changing fullscreen mode; r?rkraesig

Revision D177103 was moved to bug 1830721. Setting attachment 9331489 [details] to obsolete.

Comment 20

[Edgar Chen [:edgar]]

I have a patch to fix bug 1830721, it could be the same root cause as this.
Leave this open to verify if bug 1830721 also fixes this.

Comment 21

[Edgar Chen [:edgar]]

Bug 1830721 is now fixed in Nightly (2023-05-04 build), could you try if this bug is still reproducible on Nightly build? Thanks!

Comment 22

[Tomasz Sobczyk]

It is fixed on nightly, thank you