1830721 - firefox nightly fullscreen has borders around all sides when using userChrome.css -moz-appearance,release version has not.

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[xuizer]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

firefox nightly fullscreen has borders around all sides when using userChrome.css -moz-appearance,release version has not.
every time I switch back to the desktop and then return to fullscreen, the border disappears.

Actual results:

firefox fullscreen with borders

Expected results:

firefox fullscreen without borders

Comment 1

[xuizer]

not switching back to the desktop,minimizing and then reopening makes it disappear.

Comment 2

[Edgar Chen [:edgar]]

(In reply to xuizer from comment #0)

firefox nightly fullscreen has borders around all sides when using userChrome.css -moz-appearance

Could you share your "userChrome.css", so I could try to reproduce it?

Comment 3

[xuizer]

Attachment: userChrome.css

-moz-appearance with others can also cause this

Comment 4

[Edgar Chen [:edgar]]

This is a similar issue as bug 1830681, so this is probably caused by bug 1823284, I will take a look.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1830721 - Update non-client margins before changing fullscreen mode; r?rkraesig

We were replying on the resize event fired for fullscreen mode change to
trigger reflow. But in
https://phabricator.services.mozilla.com/D175215,
we started notifying sizemodechange after fullscreen mode has changed,
which could result in the layout not being updated properly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4a38c1b661a
Update non-client margins before changing fullscreen mode; r=rkraesig

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f4a38c1b661a

Comment 10

[Edgar Chen [:edgar]]

Comment on attachment 9331491 [details]
Bug 1830721 - Update non-client margins before changing fullscreen mode; r?rkraesig

Beta/Release Uplift Approval Request

• User impact if declined: There are blank edge around the fullscreen window, this affect Window 7 and Window 8.1 user.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Press F11 to enter browser fullscreen mode.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a straightforward fix.
• String changes made/needed: None
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Given the number of duplicate reports this is getting, tracking this for 113 after all. For those coming to this bug from elsewhere, we expect to include this fix in the 113.0.1 dot release tentatively scheduled for 23-May.

Comment 17

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 113.0 (20230504192738) on Windows 7x64 and Win 8.1x86 VM by entering fullscreen using steps from comment 10 or entering fullscreen while playing a video on youtube resulting in a border being displayed around the browser.
I can no longer reproduce the issue with Firefox 114.0b2 on Windows 7x64 and Windows 8.1 x86 VM. Entering fullscreen on a Youtube video or by using F11 will no longer display borders around the browser.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9331491 [details]
Bug 1830721 - Update non-client margins before changing fullscreen mode; r?rkraesig

We're going to ship a quick 113.0.1 dot release to address this and one or two other issues identified with the 113.0 release early next week. Approved for that.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/76daa61a91ce

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Added to the 113.0.1 relnotes:

Fixed borders being visible around fullscreen windows for some configurations

Comment 24

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 113.0.1 (20230511191846) on Windows 8.1x86 and Windows 7x64. No borders are displayed around the browser after entering Fullscreen on a video or when using the F11 keyboard key.
I have also spot-checked these scenarios on Windows 10x64, macOS 12, Ubuntu 20.04, and no borders are displayed there.