1830790 - Keep a history window of WebRTC stats for about:webrtc

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

In order to diagnose call quality issues it is helpful to have about:webrtc open as it displays a live feed of call statistics. These statistics though are not gathered until about:webrtc is opened, and so it may be difficult to analyze brief transient issues. I am proposing to keep a short window of stats (nightly pref gated), such that about:webrtc can show historical data predating the time it was opened.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P0 - Add WebRTC lifetime messages from child to parent process;r?bwc

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P1 - add WebIDL for stats history access;r?bwc

Depends on D176857

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P2 - webrtc stats history prefs;r?bwc

Depends on D176858

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P3 - add webrtc stats storage class;r?bwc

Depends on D176859

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P4 - adding webrtc hist to webrtc global info;r?bwc

Depends on D176860

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P5 - add PeerConnection lifetime message CPP decls;r?bwc

Depends on D176861

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P6 - Add PeerConnection lifetime messages to context;r?bwc

Depends on D176862

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P7 - adapt about:webrtc to use history;r?bwc

Depends on D176864

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P8 - add new prefs to the about:webrtc pref display;r?bwc

Depends on D176865

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P9 - start demuxing SDP from stats in webidl;r?bwc

Depends on D176866

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P10 - add SDP to top level of chrome only stats query callback;r?bwc

Depends on D176886

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P11 - independently store SDP in the stats history;r?bwc

Depends on D176887

Comment 13

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P12 - cache the SDP history in about:webrtc;r?bwc

Depends on D176888

Comment 14

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P13 - add SDP history to stats history results;r?bwc

Depends on D176889

Comment 15

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P14 - update about:webrtc clear stats to also clear cache;r?bwc

Depends on D176890

Comment 16

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P15 - Switch about:webrtc to use sdpHistory;r?bwc

Depends on D177426

Comment 17

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P16 - remove localSdp and remoteSdp from internal stats report;r?bwc

Depends on D178756

Comment 18

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P17 - add some basic stats hist tests;r?bwc

Depends on D178978

Comment 19

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1830790 - P18 - Some history lifetime fixes;r?bwc

Depends on D179163

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/887be68cd83e
P0 - Add WebRTC lifetime messages from child to parent process;r=bwc
https://hg.mozilla.org/integration/autoland/rev/de2dbc8d5e2a
P1 - add WebIDL for stats history access;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/18e95d0700f7
P2 - webrtc stats history prefs;r=bwc
https://hg.mozilla.org/integration/autoland/rev/f47f4c459184
P3 - add webrtc stats storage class;r=bwc
https://hg.mozilla.org/integration/autoland/rev/7d67775baf45
P4 - adding webrtc hist to webrtc global info;r=bwc
https://hg.mozilla.org/integration/autoland/rev/174a610b9939
P5 - add PeerConnection lifetime message CPP decls;r=bwc
https://hg.mozilla.org/integration/autoland/rev/74501c08f8e8
P6 - Add PeerConnection lifetime messages to context;r=bwc
https://hg.mozilla.org/integration/autoland/rev/5ff45519f3c3
P7 - adapt about:webrtc to use history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/c9975073c8f9
P8 - add new prefs to the about:webrtc pref display;r=bwc
https://hg.mozilla.org/integration/autoland/rev/bbd662a6d4f9
P9 - start demuxing SDP from stats in webidl;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/84935d63f443
P10 - add SDP to top level of chrome only stats query callback;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/0b361ee1fac2
P11 - independently store SDP in the stats history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/6ebddf918336
P12 - cache the SDP history in about:webrtc;r=bwc
https://hg.mozilla.org/integration/autoland/rev/12d356a551fb
P13 - add SDP history to stats history results;r=bwc
https://hg.mozilla.org/integration/autoland/rev/212014a98617
P14 - update about:webrtc clear stats to also clear cache;r=bwc
https://hg.mozilla.org/integration/autoland/rev/fe902e60fec3
P15 - Switch about:webrtc to use sdpHistory;r=bwc
https://hg.mozilla.org/integration/autoland/rev/b58ac93a466e
P16 - remove localSdp and remoteSdp from internal stats report;r=bwc,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/78d17b4c904f
P17 - add some basic stats hist tests;r=bwc
https://hg.mozilla.org/integration/autoland/rev/6bba4358fd61
P18 - Some history lifetime fixes;r=bwc

Comment 21

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I am investigating the following failure on autoland try:
TEST-UNEXPECTED-FAIL | browser/base/content/test/webrtc/browser_WebrtcGlobalInformation.js | After closing 13 PCs there are no more than the max closed (7) PeerConnection Ids for stats history. - Got 13, expected 7 , which is probably a simple timing issue with the test. I have a potential fix posted to Bug 1835458.

I am also going to keep my eye on Bug 1787507 .

Comment 22

[Narcis Beleuzu [:NarcisB]]

Backed out for mda failures on test_peerConnection_extmapRenegotiation.html and test_peerConnection_constructedStream.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/309b13704c6eefd8bcd6e0a772f9a5c8e426605b
Log link for test_peerConnection_extmapRenegotiation.html
Log link for test_peerConnection_constructedStream.html

Comment 23

[Nico Grunbaum [:ng, @chew:mozilla.org]]

There is something amiss in the tests being run in this chunk. Without these patches, they are only passing because they timeout in such a way as to pass without any of the test clauses being run. This seems deeply wrong. With these patches these tests progress as usual (very slowly) and pass their subtests until they run out of time and are killed.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcb4c264369e
P0 - Add WebRTC lifetime messages from child to parent process;r=bwc
https://hg.mozilla.org/integration/autoland/rev/a3d1461f8928
P1 - add WebIDL for stats history access;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/6fd62bd98d73
P2 - webrtc stats history prefs;r=bwc
https://hg.mozilla.org/integration/autoland/rev/85e101a4ff1a
P3 - add webrtc stats storage class;r=bwc
https://hg.mozilla.org/integration/autoland/rev/95473364c681
P4 - adding webrtc hist to webrtc global info;r=bwc
https://hg.mozilla.org/integration/autoland/rev/a1185664d37a
P5 - add PeerConnection lifetime message CPP decls;r=bwc
https://hg.mozilla.org/integration/autoland/rev/5885fd524e71
P6 - Add PeerConnection lifetime messages to context;r=bwc
https://hg.mozilla.org/integration/autoland/rev/8867c53e1827
P7 - adapt about:webrtc to use history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/416dc905b314
P8 - add new prefs to the about:webrtc pref display;r=bwc
https://hg.mozilla.org/integration/autoland/rev/cfb3a9040263
P9 - start demuxing SDP from stats in webidl;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/994a28147fd3
P10 - add SDP to top level of chrome only stats query callback;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/31754aa2ac82
P11 - independently store SDP in the stats history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/53848fcc501f
P12 - cache the SDP history in about:webrtc;r=bwc
https://hg.mozilla.org/integration/autoland/rev/f460416a4c52
P13 - add SDP history to stats history results;r=bwc
https://hg.mozilla.org/integration/autoland/rev/c234e91383df
P14 - update about:webrtc clear stats to also clear cache;r=bwc
https://hg.mozilla.org/integration/autoland/rev/f8ab14e89266
P15 - Switch about:webrtc to use sdpHistory;r=bwc
https://hg.mozilla.org/integration/autoland/rev/a855ea2a86ce
P16 - remove localSdp and remoteSdp from internal stats report;r=bwc,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/f40f865d0542
P17 - add some basic stats hist tests;r=bwc
https://hg.mozilla.org/integration/autoland/rev/db4607bbd6d1
P18 - Some history lifetime fixes;r=bwc

Comment 25

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_peerConnection_extmapRenegotiation.html

• backout: https://hg.mozilla.org/integration/autoland/rev/b1e97eda9232524a7fa7e071146bc9544c9ffffd
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=db4607bbd6d1046f430c2c0b7dbbefba88dc7f78&selectedTaskRun=JRdzfXhyTACEHYCgEikX7g.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=417668244&repo=autoland&lineNumber=56430

[task 2023-05-31T16:39:00.712Z] 16:39:00     INFO - TEST-PASS | dom/media/webrtc/tests/mochitests/test_peerConnection_extmapRenegotiation.html | undefined assertion name 
[task 2023-05-31T16:39:00.713Z] 16:39:00     INFO - Done running test: checkAudioIdReuseOffererThenAnswerer
[task 2023-05-31T16:39:00.714Z] 16:39:00     INFO - Running test: checkAudioUnnegotiatedIdReuse1
[task 2023-05-31T16:39:00.715Z] 16:39:00     INFO - Buffered messages finished
[task 2023-05-31T16:39:00.715Z] 16:39:00     INFO - TEST-UNEXPECTED-FAIL | dom/media/webrtc/tests/mochitests/test_peerConnection_extmapRenegotiation.html | Test timed out. - 

Comment 26

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Natalia, after inspection, that test suite is deeply broken on that specific build target, and this code is causing tests to run that were silently failing to run before. I am going to disable the test suite on that target, as per my conversation with Aryx in the Sheriff's channel.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86550861c3db
P0 - Add WebRTC lifetime messages from child to parent process;r=bwc
https://hg.mozilla.org/integration/autoland/rev/1b25f22219a8
P1 - add WebIDL for stats history access;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/0afdf2830cfb
P2 - webrtc stats history prefs;r=bwc
https://hg.mozilla.org/integration/autoland/rev/5e552e6ad3c8
P3 - add webrtc stats storage class;r=bwc
https://hg.mozilla.org/integration/autoland/rev/8a034c7f711a
P4 - adding webrtc hist to webrtc global info;r=bwc
https://hg.mozilla.org/integration/autoland/rev/b03b9764e388
P5 - add PeerConnection lifetime message CPP decls;r=bwc
https://hg.mozilla.org/integration/autoland/rev/e5273c93cf05
P6 - Add PeerConnection lifetime messages to context;r=bwc
https://hg.mozilla.org/integration/autoland/rev/d0a4a13b3b3d
P7 - adapt about:webrtc to use history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/2ac57e6f0917
P8 - add new prefs to the about:webrtc pref display;r=bwc
https://hg.mozilla.org/integration/autoland/rev/3d77c97a3fa5
P9 - start demuxing SDP from stats in webidl;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/2edb87d4fa3a
P10 - add SDP to top level of chrome only stats query callback;r=bwc,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/e9245da1cbe9
P11 - independently store SDP in the stats history;r=bwc
https://hg.mozilla.org/integration/autoland/rev/040aa11c7417
P12 - cache the SDP history in about:webrtc;r=bwc
https://hg.mozilla.org/integration/autoland/rev/a1262e211abc
P13 - add SDP history to stats history results;r=bwc
https://hg.mozilla.org/integration/autoland/rev/66a6a43f4f13
P14 - update about:webrtc clear stats to also clear cache;r=bwc
https://hg.mozilla.org/integration/autoland/rev/c61e54c27b0a
P15 - Switch about:webrtc to use sdpHistory;r=bwc
https://hg.mozilla.org/integration/autoland/rev/1fda7170d999
P16 - remove localSdp and remoteSdp from internal stats report;r=bwc,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/1f34318ec9e0
P17 - add some basic stats hist tests;r=bwc
https://hg.mozilla.org/integration/autoland/rev/17361de985dc
P18 - Some history lifetime fixes;r=bwc

Comment 28

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/86550861c3db
https://hg.mozilla.org/mozilla-central/rev/1b25f22219a8
https://hg.mozilla.org/mozilla-central/rev/0afdf2830cfb
https://hg.mozilla.org/mozilla-central/rev/5e552e6ad3c8
https://hg.mozilla.org/mozilla-central/rev/8a034c7f711a
https://hg.mozilla.org/mozilla-central/rev/b03b9764e388
https://hg.mozilla.org/mozilla-central/rev/e5273c93cf05
https://hg.mozilla.org/mozilla-central/rev/d0a4a13b3b3d
https://hg.mozilla.org/mozilla-central/rev/2ac57e6f0917
https://hg.mozilla.org/mozilla-central/rev/3d77c97a3fa5
https://hg.mozilla.org/mozilla-central/rev/2edb87d4fa3a
https://hg.mozilla.org/mozilla-central/rev/e9245da1cbe9
https://hg.mozilla.org/mozilla-central/rev/040aa11c7417
https://hg.mozilla.org/mozilla-central/rev/a1262e211abc
https://hg.mozilla.org/mozilla-central/rev/66a6a43f4f13
https://hg.mozilla.org/mozilla-central/rev/c61e54c27b0a
https://hg.mozilla.org/mozilla-central/rev/1fda7170d999
https://hg.mozilla.org/mozilla-central/rev/1f34318ec9e0
https://hg.mozilla.org/mozilla-central/rev/17361de985dc